Changeset 51192 in webkit


Ignore:
Timestamp:
Nov 19, 2009 10:16:51 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-19 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Bugzilla-tool command classes should match command names
​https://bugs.webkit.org/show_bug.cgi?id=31666

I renamed all the commands except CommitMessageForCurrentDiff because
the new name would conflict with an existing class.

  • Scripts/bugzilla-tool:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r51188 r51192  
     12009-11-19  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Bugzilla-tool command classes should match command names
     6        https://bugs.webkit.org/show_bug.cgi?id=31666
     7
     8        I renamed all the commands except CommitMessageForCurrentDiff because
     9        the new name would conflict with an existing class.
     10
     11        * Scripts/bugzilla-tool:
     12
    1132009-11-19  Pavel Feldman  <pfeldman@chromium.org>
    214

  • trunk/WebKitTools/Scripts/bugzilla-tool

    r51176 r51192  
    106106
    107107
    108 class BugsInCommitQueue(Command):
     108class BugsToCommit(Command):
    109109    def __init__(self):
    110110        Command.__init__(self, "Bugs in the commit queue")
    … …  
    116116
    117117
    118 class PatchesInCommitQueue(Command):
     118class PatchesToCommit(Command):
    119119    def __init__(self):
    120120        Command.__init__(self, "Patches in the commit queue")
    … …  
    127127
    128128
    129 class ReviewedPatchesOnBug(Command):
     129class ReviewedPatches(Command):
    130130    def __init__(self):
    131131        Command.__init__(self, "r+\'d patches on a bug", "BUGID")
    … …  
    179179
    180180
    181 class ApplyPatchesFromBug(Command):
     181class ApplyPatches(Command):
    182182    def __init__(self):
    183183        options = WebKitApplyingScripts.apply_options() + WebKitLandingScripts.cleaning_options()
    … …  
    356356
    357357
    358 class LandAndUpdateBug(Command):
     358class LandDiff(Command):
    359359    def __init__(self):
    360360        options = [
    … …  
    454454
    455455
    456 class LandPatchesFromBugs(AbstractPatchLandingCommand):
     456class LandPatches(AbstractPatchLandingCommand):
    457457    def __init__(self):
    458458        AbstractPatchLandingCommand.__init__(self, "Lands all patches on the given bugs, optionally building and testing them first", "BUGID [BUGIDS]")
    … …  
    477477
    478478
    479 class ObsoleteAttachmentsOnBug(Command):
     479class ObsoleteAttachments(Command):
    480480    def __init__(self):
    481481        Command.__init__(self, "Marks all attachments on a bug as obsolete.", "BUGID")
    … …  
    489489
    490490
    491 class PostDiffAsPatchToBug(Command):
     491class PostDiff(Command):
    492492    def __init__(self):
    493493        options = [
    … …  
    529529
    530530
    531 class PostCommitsAsPatchesToBug(Command):
     531class PostCommits(Command):
    532532    def __init__(self):
    533533        options = [
    … …  
    536536            make_option("-m", "--description", action="store", type="string", dest="description", help="Description string for the attachment (default: description from commit message)"),
    537537        ]
    538         options += PostDiffAsPatchToBug.posting_options()
     538        options += PostDiff.posting_options()
    539539        Command.__init__(self, "Attaches a range of local commits to bugs as patch files.", "COMMITISH", options=options, requires_local_commits=True)
    540540
    … …  
    570570
    571571            if options.obsolete_patches and bug_id not in have_obsoleted_patches:
    572                 PostDiffAsPatchToBug.obsolete_patches_on_bug(bug_id, tool.bugs)
     572                PostDiff.obsolete_patches_on_bug(bug_id, tool.bugs)
    573573                have_obsoleted_patches.add(bug_id)
    574574
    … …  
    579579
    580580
    581 class RolloutCommit(Command):
     581class Rollout(Command):
    582582    def __init__(self):
    583583        options = WebKitLandingScripts.land_options()
    … …  
    673673            options.obsolete_patches = False
    674674            # FIXME: We should pass through --no-comment switch as well.
    675             PostCommitsAsPatchesToBug.execute(self, options, commit_ids[1:], tool)
     675            PostCommits.execute(self, options, commit_ids[1:], tool)
    676676
    677677    def create_bug_from_patch(self, options, args, tool):
    … …  
    713713
    714714
    715 class CheckTreeStatus(Command):
     715class TreeStatus(Command):
    716716    def __init__(self):
    717717        Command.__init__(self, "Print out the status of the webkit builders.")
    … …  
    857857        self.buildbot = BuildBot()
    858858        self.commands = [
    859             { "name" : "bugs-to-commit", "object" : BugsInCommitQueue() },
    860             { "name" : "patches-to-commit", "object" : PatchesInCommitQueue() },
    861             { "name" : "reviewed-patches", "object" : ReviewedPatchesOnBug() },
     859            { "name" : "bugs-to-commit", "object" : BugsToCommit() },
     860            { "name" : "patches-to-commit", "object" : PatchesToCommit() },
     861            { "name" : "reviewed-patches", "object" : ReviewedPatches() },
    862862            { "name" : "create-bug", "object" : CreateBug() },
    863863            { "name" : "apply-attachment", "object" : ApplyAttachment() },
    864             { "name" : "apply-patches", "object" : ApplyPatchesFromBug() },
    865             { "name" : "land-diff", "object" : LandAndUpdateBug() },
     864            { "name" : "apply-patches", "object" : ApplyPatches() },
     865            { "name" : "land-diff", "object" : LandDiff() },
    866866            { "name" : "land-attachment", "object" : LandAttachment() },
    867             { "name" : "land-patches", "object" : LandPatchesFromBugs() },
     867            { "name" : "land-patches", "object" : LandPatches() },
    868868            { "name" : "check-style", "object" : CheckStyle() },
    869869            { "name" : "commit-message", "object" : CommitMessageForCurrentDiff() },
    870             { "name" : "obsolete-attachments", "object" : ObsoleteAttachmentsOnBug() },
    871             { "name" : "post-diff", "object" : PostDiffAsPatchToBug() },
    872             { "name" : "post-commits", "object" : PostCommitsAsPatchesToBug() },
    873             { "name" : "tree-status", "object" : CheckTreeStatus() },
     870            { "name" : "obsolete-attachments", "object" : ObsoleteAttachments() },
     871            { "name" : "post-diff", "object" : PostDiff() },
     872            { "name" : "post-commits", "object" : PostCommits() },
     873            { "name" : "tree-status", "object" : TreeStatus() },
    874874            { "name" : "commit-queue", "object" : CommitQueue() },
    875875            { "name" : "style-queue", "object" : StyleQueue() },
    876             { "name" : "rollout", "object" : RolloutCommit() },
     876            { "name" : "rollout", "object" : Rollout() },
    877877        ]
    878878
Note: See TracChangeset for help on using the changeset viewer.