Changeset 51202 in webkit
- Timestamp:
- Nov 19, 2009 12:28:09 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r51196 r51202 1 2009-11-19 Eric Seidel <eric@webkit.org> 2 3 Reviewed by Darin Adler. 4 5 bugzilla-tool's reviewer/committer rejection message should be clearer 6 https://bugs.webkit.org/show_bug.cgi?id=31126 7 8 Add more explanatory prose to bugzilla-tool's flag permission rejection message. 9 10 * Scripts/modules/bugzilla.py: 11 1 12 2009-11-19 Eric Z. Ayers <zundel@google.com> 2 13 -
trunk/WebKitTools/Scripts/modules/bugzilla.py
r51085 r51202 240 240 return "http://trac.webkit.org/browser/trunk/%s" % local_path 241 241 242 def _flag_permission_rejection_message(self, setter_email, flag_name): 243 committer_list = "WebKitTools/Scripts/modules/committers.py" 244 contribution_guidlines_url = "http://webkit.org/coding/contributing.html" 245 rejection_message = "%s does not have %s permissions according to %s." % (setter_email, flag_name, self._view_source_link(committer_list)) 246 rejection_message += "\n\n- If you have %s rights please correct the error in %s by adding yourself to the file (no review needed) and then set the %s flag again." % (flag_name, committer_list, flag_name) 247 rejection_message += "\n\n- If you do not have %s rights please read %s for instructions on how to use bugzilla flags." % (flag_name, contribution_guidlines_url) 248 return rejection_message 249 242 250 def _validate_setter_email(self, patch, result_key, lookup_function, rejection_function, reject_invalid_patches): 243 251 setter_email = patch.get(result_key + '_email') … … 251 259 252 260 if reject_invalid_patches: 253 committer_list = "WebKitTools/Scripts/modules/committers.py" 254 failure_message = "%s does not have %s permissions according to %s." % (setter_email, result_key, self._view_source_link(committer_list)) 255 rejection_function(patch['id'], failure_message) 261 rejection_function(patch['id'], self._flag_permission_rejection_message(setter_email, result_key)) 256 262 else: 257 263 log("Warning, attachment %s on bug %s has invalid %s (%s)" % (patch['id'], patch['bug_id'], result_key, setter_email))
Note: See TracChangeset
for help on using the changeset viewer.