Changeset 51242 in webkit

Timestamp:

Nov 20, 2009 10:40:57 AM (14 years ago)

Author:

bweinstein@apple.com

Message:

Fixes <​http://webkit.org/b/31699>.
Web Inspector: Should Cache Values of InspectorController.platform() and port().

Reviewed by Tim Hatcher.

Refactor the Inspector to cache the value of InspectorController.platform
and InspectorController.port, because those need to call into C++, they are
being called more and more as we add platform specific keyboard shortcuts, and
they shouldn't change in the lifecycle of the Web Inspector.

• inspector/front-end/AbstractTimelinePanel.js:

(WebInspector.AbstractTimelinePanel.prototype._updateFilter):

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._updateFilter):

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleKeyEvent):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._loaded):

• inspector/front-end/inspector.js:

(WebInspector.get platform):
(WebInspector.get port):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.toolbarDragStart):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (2 diffs)
• inspector/front-end/AbstractTimelinePanel.js (modified) (1 diff)
• inspector/front-end/ConsoleView.js (modified) (1 diff)
• inspector/front-end/ElementsPanel.js (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (1 diff)
• inspector/front-end/SourceFrame.js (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-20  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Tim Hatcher.
+
+        Fixes <http://webkit.org/b/31699>.
+        Web Inspector: Should Cache Values of InspectorController.platform() and port().
+
+        Refactor the Inspector to cache the value of InspectorController.platform
+        and InspectorController.port, because those need to call into C++, they are
+        being called more and more as we add platform specific keyboard shortcuts, and
+        they shouldn't change in the lifecycle of the Web Inspector.
+
+        * inspector/front-end/AbstractTimelinePanel.js:
+        (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._updateFilter):
+        * inspector/front-end/ElementsPanel.js:
+        (WebInspector.ElementsPanel.prototype.handleKeyEvent):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel):
+        * inspector/front-end/SourceFrame.js:
+        (WebInspector.SourceFrame.prototype._loaded):
+        * inspector/front-end/inspector.js:
+        (WebInspector.get platform):
+        (WebInspector.get port):
+        (WebInspector.loaded):
+        (WebInspector.documentKeyDown):
+        (WebInspector.toolbarDragStart):
+
 2009-11-20  Dirk Schulze  <krit@webkit.org>
 
@@ -104 +133 @@
         Test: fast/ruby/ruby-text-indent.html
 
-        * css/html.css: reset text-indent on <ruby> and <rt> elements 
+        * css/html.css: reset text-indent on <ruby> and <rt> elements
 
 2009-11-19  Brian Weinstein  <bweinstein@apple.com>

trunk/WebCore/inspector/front-end/AbstractTimelinePanel.js

@@ -190 +190 @@
     _updateFilter: function(e)
     {
-        var isMac = InspectorController.platform().indexOf("mac-") === 0;
+        var isMac = WebInspector.platform.indexOf("mac-") === 0;
         var selectMultiple = false;
         if (isMac && e.metaKey && !e.ctrlKey && !e.altKey && !e.shiftKey)

trunk/WebCore/inspector/front-end/ConsoleView.js

@@ -102 +102 @@
     _updateFilter: function(e)
     {
-        var isMac = InspectorController.platform().indexOf("mac-") === 0;
+        var isMac = WebInspector.platform.indexOf("mac-") === 0;
         var selectMultiple = false;
         if (isMac && e.metaKey && !e.ctrlKey && !e.altKey && !e.shiftKey)

trunk/WebCore/inspector/front-end/ElementsPanel.js

@@ -1002 +1002 @@
         // This shortcut matches Firebug.
         if (event.keyIdentifier === "U+0043") {     // C key
-            var isMac = InspectorController.platform().indexOf("mac-") === 0;
+            var isMac = WebInspector.platform.indexOf("mac-") === 0;
             if (isMac)
                 var isNodeSearchKey = event.metaKey && !event.ctrlKey && !event.altKey && event.shiftKey;

trunk/WebCore/inspector/front-end/ScriptsPanel.js

@@ -163 +163 @@
     this._shortcuts = {};
 
-    var isMac = InspectorController.platform().indexOf("mac-") === 0;
+    var isMac = WebInspector.platform.indexOf("mac-") === 0;
     var platformSpecificModifier = isMac ? WebInspector.KeyboardShortcut.Modifiers.Meta : WebInspector.KeyboardShortcut.Modifiers.Ctrl;
 

trunk/WebCore/inspector/front-end/SourceFrame.js

@@ -208 +208 @@
 
         // Register 'eval' shortcut.
-        var isMac = InspectorController.platform().indexOf("mac-") === 0;
+        var isMac = WebInspector.platform.indexOf("mac-") === 0;
         var platformSpecificModifier = isMac ? WebInspector.KeyboardShortcut.Modifiers.Meta : WebInspector.KeyboardShortcut.Modifiers.Ctrl;
         var shortcut = WebInspector.KeyboardShortcut.makeKey(69 /* 'E' */, platformSpecificModifier | WebInspector.KeyboardShortcut.Modifiers.Shift);

trunk/WebCore/inspector/front-end/inspector.js

@@ -73 +73 @@
     cookieDomains: {},
     missingLocalizedStrings: {},
+    
+    get platform()
+    {
+        if (!("_platform" in this))
+            this._platform = InspectorController.platform();
+        
+        return this._platform;
+    },
+    
+    get port()
+    {
+        if (!("_port" in this))
+            this._port = InspectorController.port();
+        
+        return this._port;
+    },
 
     get previousFocusElement()
@@ -391 +407 @@
 WebInspector.loaded = function()
 {
-    var platform = InspectorController.platform();
+    var platform = WebInspector.platform;
     document.body.addStyleClass("platform-" + platform);
-    var port = InspectorController.port();
+    var port = WebInspector.port;
     document.body.addStyleClass("port-" + port);
 
@@ -621 +637 @@
 
     if (!event.handled) {
-        var isMac = InspectorController.platform().indexOf("mac-") === 0;
+        var isMac = WebInspector.platform.indexOf("mac-") === 0;
 
         switch (event.keyIdentifier) {
@@ -846 +862 @@
 WebInspector.toolbarDragStart = function(event)
 {
-    if ((!WebInspector.attached && InspectorController.platform() !== "mac-leopard") || InspectorController.port() == "qt")
+    if ((!WebInspector.attached && WebInspector.platform !== "mac-leopard") || WebInspector.port == "qt")
         return;