Changeset 51316 in webkit

Timestamp:

Nov 23, 2009 1:48:11 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-23 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
​https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

• platform/qt/Skipped:

2009-11-23 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
​https://bugs.webkit.org/show_bug.cgi?id=31775

LayoutTestController::dumpBackForwardList() should work with local URLs
as well as with normal URLs (in http tests for instance).
Currently it does not output the latter properly.

Unskip a bunch of passing http/navigation tests.

• DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::dumpHistoryItem):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (2 diffs)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
+        https://bugs.webkit.org/show_bug.cgi?id=31775
+
+        LayoutTestController::dumpBackForwardList() should work with local URLs
+        as well as with normal URLs (in http tests for instance).
+        Currently it does not output the latter properly.
+
+        Unskip a bunch of passing http/navigation tests.
+
+        * platform/qt/Skipped:
+
 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -36 +36 @@
 http/tests/incremental
 http/tests/media
-http/tests/navigation
 http/tests/plugins
 http/tests/webarchive
@@ -68 +67 @@
 http/tests/local/drag-over-remote-content.html
 http/tests/local/send-dragged-file.html
+
+# Failing navigation tests
+http/tests/navigation/anchor-frames.html
+http/tests/navigation/anchor-subframeload.html
+http/tests/navigation/back-to-slow-frame.html
+http/tests/navigation/changing-frame-hierarchy-in-onload.html
+http/tests/navigation/error404-basic.html
+http/tests/navigation/error404-frames.html
+http/tests/navigation/error404-goback.html
+http/tests/navigation/error404-subframeload.html
+http/tests/navigation/javascriptlink-basic.html
+http/tests/navigation/javascriptlink-frames.html
+http/tests/navigation/javascriptlink-goback.html
+http/tests/navigation/javascriptlink-subframeload.html
+http/tests/navigation/lockedhistory-iframe.html
+http/tests/navigation/metaredirect-basic.html
+http/tests/navigation/metaredirect-frames.html
+http/tests/navigation/metaredirect-goback.html
+http/tests/navigation/metaredirect-subframeload.html
+http/tests/navigation/new-window-redirect-history.html
+http/tests/navigation/no-referrer-reset.html
+http/tests/navigation/no-referrer-target-blank.html
+http/tests/navigation/onload-navigation-iframe-2.html
+http/tests/navigation/onload-navigation-iframe-timeout.html
+http/tests/navigation/onload-navigation-iframe.html
+http/tests/navigation/post-basic.html
+http/tests/navigation/post-frames.html
+http/tests/navigation/post-goback1.html
+http/tests/navigation/post-goback2.html
+http/tests/navigation/postredirect-basic.html
+http/tests/navigation/postredirect-frames.html
+http/tests/navigation/postredirect-goback1.html
+http/tests/navigation/postredirect-goback2.html
+http/tests/navigation/redirect302-frames.html
+http/tests/navigation/redirect302-subframeload.html
+http/tests/navigation/relativeanchor-frames.html
+http/tests/navigation/reload-subframe-object.html
+http/tests/navigation/slowmetaredirect-basic.html
+http/tests/navigation/slowtimerredirect-basic.html
+http/tests/navigation/success200-frames-loadsame.html
+http/tests/navigation/success200-frames.html
+http/tests/navigation/success200-subframeload.html
+http/tests/navigation/target-frame-from-window.html
+http/tests/navigation/timerredirect-basic.html
+http/tests/navigation/timerredirect-frames.html
+http/tests/navigation/timerredirect-goback.html
+http/tests/navigation/timerredirect-subframeload.html
 
 # Failing security tests

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
+        https://bugs.webkit.org/show_bug.cgi?id=31775
+
+        LayoutTestController::dumpBackForwardList() should work with local URLs
+        as well as with normal URLs (in http tests for instance).
+        Currently it does not output the latter properly.
+
+        Unskip a bunch of passing http/navigation tests.
+
+        * DumpRenderTree/qt/DumpRenderTree.cpp:
+        (WebCore::dumpHistoryItem):
+
 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
 

trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp

@@ -510 +510 @@
         result.append(fileTestString);
         result.append(res);
-
-        // FIXME: Wrong, need (private?) API for determining this.
-        result.append(QLatin1String("  **nav target**"));
-    }
+    } else {
+        result.append(url);
+    }
+
+    // FIXME: Wrong, need (private?) API for determining this.
+    result.append(QLatin1String("  **nav target**"));
     result.append(QLatin1String("\n"));