Changeset 51343 in webkit


Ignore:
Timestamp:
Nov 24, 2009 10:55:13 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-11-24 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
https://bugs.webkit.org/show_bug.cgi?id=26354

Implemented MediaPlayerPrivate::isAvailable by checking the
presence of the playbin2 GStreamer element.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::isAvailable):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r51342 r51343  
     12009-11-24  Philippe Normand  <pnormand@igalia.com>
     2
     3        Reviewed by Gustavo Noronha Silva.
     4
     5        [Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
     6        https://bugs.webkit.org/show_bug.cgi?id=26354
     7
     8        Implemented MediaPlayerPrivate::isAvailable by checking the
     9        presence of the playbin2 GStreamer element.
     10
     11        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
     12        (WebCore::MediaPlayerPrivate::isAvailable):
     13        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
     14
    1152009-11-24  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
    216
  • trunk/WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp

    r50873 r51343  
    159159}
    160160
     161bool MediaPlayerPrivate::isAvailable()
     162{
     163    do_gst_init();
     164    GstElementFactory* factory = gst_element_factory_find("playbin2");
     165    if (factory) {
     166        gst_object_unref(GST_OBJECT(factory));
     167        return true;
     168    }
     169    return false;
     170}
     171
    161172MediaPlayerPrivate::MediaPlayerPrivate(MediaPlayer* player)
    162173    : m_player(player)
  • trunk/WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.h

    r50726 r51343  
    110110            static void getSupportedTypes(HashSet<String>&);
    111111            static MediaPlayer::SupportsType supportsType(const String& type, const String& codecs);
    112             static bool isAvailable() { return true; }
     112            static bool isAvailable();
    113113
    114114            void updateStates();
Note: See TracChangeset for help on using the changeset viewer.