Changeset 51391 in webkit


Ignore:
Timestamp:
Nov 25, 2009 12:02:12 PM (14 years ago)
Author:
zoltan@webkit.org
Message:

2009-11-25 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Change run_command to give back stderr by default
https://bugs.webkit.org/show_bug.cgi?id=31734

Change run_command to give back stderr by default.
Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
Change the related unittest call.

  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r51383 r51391  
     12009-11-25  Zoltan Horvath  <zoltan@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Change run_command to give back stderr by default
     6        https://bugs.webkit.org/show_bug.cgi?id=31734
     7
     8        Change run_command to give back stderr by default.
     9        Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
     10        Change the related unittest call.
     11
     12        * Scripts/modules/scm.py:
     13        * Scripts/modules/scm_unittest.py:
     14
    1152009-11-25  Eric Seidel  <eric@webkit.org>
    216
  • trunk/WebKitTools/Scripts/modules/scm.py

    r51230 r51391  
    124124
    125125    @staticmethod
    126     def run_command(args, cwd=None, input=None, error_handler=default_error_handler, return_exit_code=False, return_stderr=False):
     126    def run_command(args, cwd=None, input=None, error_handler=default_error_handler, return_exit_code=False, return_stderr=True):
    127127        if hasattr(input, 'read'): # Check if the input is a file.
    128128            stdin = input
     
    361361
    362362    def create_patch(self):
    363         return self.run_command(self.script_path("svn-create-patch"), cwd=self.checkout_root)
     363        return self.run_command(self.script_path("svn-create-patch"), cwd=self.checkout_root, return_stderr=False)
    364364
    365365    def diff_for_revision(self, revision):
  • trunk/WebKitTools/Scripts/modules/scm_unittest.py

    r51230 r51391  
    155155        self.assertRaises(ScriptError, SCM.run_command, command_returns_non_zero)
    156156        # Check if returns error text:
    157         self.assertTrue(SCM.run_command(command_returns_non_zero, error_handler=ignore_error, return_stderr=True))
     157        self.assertTrue(SCM.run_command(command_returns_non_zero, error_handler=ignore_error))
    158158
    159159        self.assertRaises(CheckoutNeedsUpdate, commit_error_handler, ScriptError(output=git_failure_message))
Note: See TracChangeset for help on using the changeset viewer.