Changeset 51411 in webkit

Timestamp:

Nov 26, 2009 3:16:23 AM (14 years ago)

Author:

zecke@webkit.org

Message:

[Qt] Use QNetworkReply::rawHeaderPairs

​https://bugs.webkit.org/show_bug.cgi?id=31826

The QNetworkReply is internally storing the HTTP headers
as a list of pairs. Currently we have to ask the QNetworkReply
to put all header names into a QStringList. Afterwards we will
iterate over this QStringList and ask the QNetworkReply to
give us the value for this header name. The current Qt implementation
is doing a linear to find the header value.

Use a new API to directly access the list of pairs and push
this into WebCore. This avoids doing some allocations and doing
linear searches from within a loop.

• platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/qt/QNetworkReplyHandler.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
+
+        Reviewed by Eric Seidel.
+
+        [Qt] Use QNetworkReply::rawHeaderPairs
+        https://bugs.webkit.org/show_bug.cgi?id=31826
+
+        The QNetworkReply is internally storing the HTTP headers
+        as a list of pairs. Currently we have to ask the QNetworkReply
+        to put all header names into a QStringList. Afterwards we will
+        iterate over this QStringList and ask the QNetworkReply to
+        give us the value for this header name. The current Qt implementation
+        is doing a linear to find the header value.
+
+        Use a new API to directly access the list of pairs and push
+        this into WebCore. This avoids doing some allocations and doing
+        linear searches from within a loop.
+
+        * platform/network/qt/QNetworkReplyHandler.cpp:
+        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
+
 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
 

trunk/WebCore/platform/network/qt/QNetworkReplyHandler.cpp

@@ -308 +308 @@
 
         // Add remaining headers.
+#if QT_VERSION >= QT_VERSION_CHECK(4, 7, 0)
+        foreach (const QNetworkReply::RawHeaderPair& pair, m_reply->rawHeaderPairs()) {
+            response.setHTTPHeaderField(QString::fromAscii(pair.first), QString::fromAscii(pair.second));
+        }
+#else
         foreach (const QByteArray& headerName, m_reply->rawHeaderList()) {
             response.setHTTPHeaderField(QString::fromAscii(headerName), QString::fromAscii(m_reply->rawHeader(headerName)));
         }
+#endif
     }