Changeset 51432 in webkit


Ignore:
Timestamp:
Nov 26, 2009 11:55:31 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2009-11-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Step 2: Kill ensure_builders_are_green.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/webkitlandingscripts.py:
Location:
trunk/WebKitTools
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r51431 r51432  
     12009-11-26  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [bzt] Kill WebKitLandingScripts
     6        https://bugs.webkit.org/show_bug.cgi?id=31904
     7
     8        Step 2: Kill ensure_builders_are_green.
     9
     10        * Scripts/modules/buildsteps.py:
     11        * Scripts/modules/commands/download.py:
     12        * Scripts/modules/landingsequence.py:
     13        * Scripts/modules/webkitlandingscripts.py:
     14
    1152009-11-26  Adam Barth  <abarth@webkit.org>
    216
  • trunk/WebKitTools/Scripts/modules/buildsteps.py

    r51431 r51432  
    2929import os
    3030
     31from modules.logging import error
    3132from modules.webkitlandingscripts import WebKitLandingScripts
    3233from modules.webkitport import WebKitPort
     
    4950            args.append("--exit-after-n-failures=1")
    5051        WebKitLandingScripts.run_and_throw_if_fail(args)
     52
     53    def ensure_builders_are_green(self, buildbot, options):
     54        if not options.check_builders or buildbot.core_builders_are_green():
     55            return
     56        error("Builders at %s are red, please do not commit.  Pass --ignore-builders to bypass this check." % (buildbot.buildbot_host))
  • trunk/WebKitTools/Scripts/modules/commands/download.py

    r51431 r51432  
    199199        bug_id = (args and args[0]) or parse_bug_id(tool.scm().create_patch())
    200200
    201         WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)
     201        tool.steps.ensure_builders_are_green(tool.buildbot, options)
    202202
    203203        os.chdir(tool.scm().checkout_root)
     
    301301    def _prepare_to_process(self, options, args, tool):
    302302        # Check the tree status first so we can fail early.
    303         WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)
     303        tool.steps.ensure_builders_are_green(tool.buildbot, options)
    304304
    305305    def _process_patch(self, patch, options, args, tool):
     
    317317    def _prepare_to_process(self, options, args, tool):
    318318        # Check the tree status first so we can fail early.
    319         WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)
     319        tool.steps.ensure_builders_are_green(tool.buildbot, options)
    320320
    321321    def _process_patch(self, patch, options, args, tool):
  • trunk/WebKitTools/Scripts/modules/landingsequence.py

    r51431 r51432  
    8181        # Make sure the tree is still green after updating, before building this patch.
    8282        # The first patch ends up checking tree status twice, but that's OK.
    83         WebKitLandingScripts.ensure_builders_are_green(self._tool.buildbot, self._options)
     83        self._tool.steps.ensure_builders_are_green(self._tool.buildbot, self._options)
    8484        WebKitLandingScripts.build_webkit(quiet=self._options.quiet, port=self._port)
    8585
  • trunk/WebKitTools/Scripts/modules/webkitlandingscripts.py

    r51431 r51432  
    124124        cls.run_and_throw_if_fail(port.build_webkit_command(), quiet)
    125125
    126     @staticmethod
    127     def ensure_builders_are_green(buildbot, options):
    128         if not options.check_builders or buildbot.core_builders_are_green():
    129             return
    130         error("Builders at %s are red, please do not commit.  Pass --ignore-builders to bypass this check." % (buildbot.buildbot_host))
    131126
    132127
Note: See TracChangeset for help on using the changeset viewer.