Changeset 51432 in webkit
- Timestamp:
- Nov 26, 2009 11:55:31 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r51431 r51432 1 2009-11-26 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 [bzt] Kill WebKitLandingScripts 6 https://bugs.webkit.org/show_bug.cgi?id=31904 7 8 Step 2: Kill ensure_builders_are_green. 9 10 * Scripts/modules/buildsteps.py: 11 * Scripts/modules/commands/download.py: 12 * Scripts/modules/landingsequence.py: 13 * Scripts/modules/webkitlandingscripts.py: 14 1 15 2009-11-26 Adam Barth <abarth@webkit.org> 2 16 -
trunk/WebKitTools/Scripts/modules/buildsteps.py
r51431 r51432 29 29 import os 30 30 31 from modules.logging import error 31 32 from modules.webkitlandingscripts import WebKitLandingScripts 32 33 from modules.webkitport import WebKitPort … … 49 50 args.append("--exit-after-n-failures=1") 50 51 WebKitLandingScripts.run_and_throw_if_fail(args) 52 53 def ensure_builders_are_green(self, buildbot, options): 54 if not options.check_builders or buildbot.core_builders_are_green(): 55 return 56 error("Builders at %s are red, please do not commit. Pass --ignore-builders to bypass this check." % (buildbot.buildbot_host)) -
trunk/WebKitTools/Scripts/modules/commands/download.py
r51431 r51432 199 199 bug_id = (args and args[0]) or parse_bug_id(tool.scm().create_patch()) 200 200 201 WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)201 tool.steps.ensure_builders_are_green(tool.buildbot, options) 202 202 203 203 os.chdir(tool.scm().checkout_root) … … 301 301 def _prepare_to_process(self, options, args, tool): 302 302 # Check the tree status first so we can fail early. 303 WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)303 tool.steps.ensure_builders_are_green(tool.buildbot, options) 304 304 305 305 def _process_patch(self, patch, options, args, tool): … … 317 317 def _prepare_to_process(self, options, args, tool): 318 318 # Check the tree status first so we can fail early. 319 WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)319 tool.steps.ensure_builders_are_green(tool.buildbot, options) 320 320 321 321 def _process_patch(self, patch, options, args, tool): -
trunk/WebKitTools/Scripts/modules/landingsequence.py
r51431 r51432 81 81 # Make sure the tree is still green after updating, before building this patch. 82 82 # The first patch ends up checking tree status twice, but that's OK. 83 WebKitLandingScripts.ensure_builders_are_green(self._tool.buildbot, self._options)83 self._tool.steps.ensure_builders_are_green(self._tool.buildbot, self._options) 84 84 WebKitLandingScripts.build_webkit(quiet=self._options.quiet, port=self._port) 85 85 -
trunk/WebKitTools/Scripts/modules/webkitlandingscripts.py
r51431 r51432 124 124 cls.run_and_throw_if_fail(port.build_webkit_command(), quiet) 125 125 126 @staticmethod127 def ensure_builders_are_green(buildbot, options):128 if not options.check_builders or buildbot.core_builders_are_green():129 return130 error("Builders at %s are red, please do not commit. Pass --ignore-builders to bypass this check." % (buildbot.buildbot_host))131 126 132 127
Note: See TracChangeset
for help on using the changeset viewer.