Changeset 51433 in webkit

Timestamp:

Nov 26, 2009 11:55:57 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-11-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Kill WebKitLandingScripts
​https://bugs.webkit.org/show_bug.cgi?id=31904

Step 3: Kill build_webkit.

• Scripts/modules/buildsteps.py:
• Scripts/modules/landingsequence.py:
• Scripts/modules/webkitlandingscripts.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/buildsteps.py (modified) (1 diff)
• Scripts/modules/landingsequence.py (modified) (1 diff)
• Scripts/modules/webkitlandingscripts.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-26  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] Kill WebKitLandingScripts
+        https://bugs.webkit.org/show_bug.cgi?id=31904
+
+        Step 3: Kill build_webkit.
+
+        * Scripts/modules/buildsteps.py:
+        * Scripts/modules/landingsequence.py:
+        * Scripts/modules/webkitlandingscripts.py:
+
 2009-11-26  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/modules/buildsteps.py

@@ -55 +55 @@
             return
         error("Builders at %s are red, please do not commit.  Pass --ignore-builders to bypass this check." % (buildbot.buildbot_host))
+
+    def build_webkit(self, quiet=False, port=WebKitPort):
+        log("Building WebKit")
+        WebKitLandingScripts.run_and_throw_if_fail(port.build_webkit_command(), quiet)

trunk/WebKitTools/Scripts/modules/landingsequence.py

@@ -82 +82 @@
         # The first patch ends up checking tree status twice, but that's OK.
         self._tool.steps.ensure_builders_are_green(self._tool.buildbot, self._options)
-        WebKitLandingScripts.build_webkit(quiet=self._options.quiet, port=self._port)
+        self._tool.steps.build_webkit(quiet=self._options.quiet, port=self._port)
 
     def test(self):

trunk/WebKitTools/Scripts/modules/webkitlandingscripts.py

@@ -119 +119 @@
         cls.run_and_throw_if_fail(port.script_path(script_name), quiet)
 
-    @classmethod
-    def build_webkit(cls, quiet=False, port=WebKitPort):
-        log("Building WebKit")
-        cls.run_and_throw_if_fail(port.build_webkit_command(), quiet)