Changeset 51471 in webkit

Timestamp:

Nov 29, 2009 5:02:43 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-29 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Test using Id as index of node list.
​https://bugs.webkit.org/show_bug.cgi?id=31428

• fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
• fast/dom/Element/id-in-node-list-index01.html: Added.

2009-11-29 Shu Chang <​Chang.Shu@nokia.com>

Reviewed by Eric Seidel.

Continue to search for matching node in the case where multiple nodes
have the same id.
​https://bugs.webkit.org/show_bug.cgi?id=31428

Test: fast/dom/Element/id-in-node-list-index01.html

• dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/Element/id-in-node-list-index01-expected.txt (added)
• LayoutTests/fast/dom/Element/id-in-node-list-index01.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/DynamicNodeList.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-11-29  Shu Chang  <Chang.Shu@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Test using Id as index of node list.
+        https://bugs.webkit.org/show_bug.cgi?id=31428
+
+        * fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
+        * fast/dom/Element/id-in-node-list-index01.html: Added.
+
 2009-11-28  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-11-29  Shu Chang  <Chang.Shu@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Continue to search for matching node in the case where multiple nodes
+        have the same id.
+        https://bugs.webkit.org/show_bug.cgi?id=31428
+
+        Test: fast/dom/Element/id-in-node-list-index01.html
+
+        * dom/DynamicNodeList.cpp:
+        (WebCore::DynamicNodeList::itemWithName):
+
 2009-11-29  Daniel Bates  <dbates@webkit.org>
 

trunk/WebCore/dom/DynamicNodeList.cpp

@@ -130 +130 @@
             }
         }
-        return 0;
+        if (!node)
+            return 0;
+        // In the case of multiple nodes with the same name, just fall through.
     }