Changeset 51518 in webkit

Timestamp:

Nov 30, 2009 4:07:41 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-11-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Generate pass messages for style-queue
​https://bugs.webkit.org/show_bug.cgi?id=31995

With this change, the style-queue posts "pass" messages to bugs as
well. Also, added more information to the state store w.r.t. passing
and failing.

• Scripts/modules/commands/queues.py:
• Scripts/modules/patchcollection.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/commands/queues.py (modified) (4 diffs)
• Scripts/modules/patchcollection.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-11-30  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] Generate pass messages for style-queue
+        https://bugs.webkit.org/show_bug.cgi?id=31995
+
+        With this change, the style-queue posts "pass" messages to bugs as
+        well.  Also, added more information to the state store w.r.t. passing
+        and failing.
+
+        * Scripts/modules/commands/queues.py:
+        * Scripts/modules/patchcollection.py:
+
 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/WebKitTools/Scripts/modules/commands/queues.py

@@ -191 +191 @@
     def handle_unexpected_error(self, patch, message):
         log(message)
-        self._patches.done(patch)
 
     # LandingSequenceErrorHandler methods
@@ -210 +209 @@
 
     def process_work_item(self, patch):
-        self.run_bugzilla_tool(["check-style", "--force-clean", "--non-interactive", "--parent-command=style-queue", patch["id"]])
-        self._patches.done(patch)
+        try:
+            self.run_bugzilla_tool(["check-style", "--force-clean", "--non-interactive", "--parent-command=style-queue", patch["id"]])
+            message = "%s ran check-webkit-style on attachment %s without any errors." % (self.name, patch["id"])
+            self.tool.bugs.post_comment_to_bug(patch["bug_id"], message, cc=self.watchers)
+            self._patches.did_pass(patch)
+        except ScriptError, e:
+            self._patches.did_fail(patch)
+            raise e
 
     @classmethod
@@ -221 +226 @@
         #        have a better API.
         if re.search("check-webkit-style", command):
-            message = "Attachment %s did not pass %s:\n\n%s" % (patch["id"], cls.name, script_error.message_with_output(output_limit=None))
-            # Local-only logging helpful for development:
-            # log("** BEGIN BUG POST **\n%s** END BUG POST **" % message)
+            message = "Attachment %s did not pass %s:\n\n%s" % (patch["id"], cls.name, script_error.message_with_output(output_limit=5*1024))
             tool.bugs.post_comment_to_bug(patch["bug_id"], message, cc=cls.watchers)
 
@@ -247 +250 @@
     def process_work_item(self, patch):
         self.run_bugzilla_tool(["build-attachment", self.port.flag(), "--force-clean", "--quiet", "--non-interactive", "--parent-command=build-queue", "--no-update", patch["id"]])
-        self._patches.done(patch)
+        self._patches.did_pass(patch)

trunk/WebKitTools/Scripts/modules/patchcollection.py

@@ -72 +72 @@
 
 class PersistentPatchCollection:
-    _initial_status = "Attempted"
-    _terminal_status = "Done"
+    _initial_status = "Pending"
+    _pass_status = "Pass"
+    _fail_status = "Fail"
     def __init__(self, delegate):
         self._delegate = delegate
@@ -96 +97 @@
                 return patch_id
 
-    def done(self, patch):
-        self._status.update_status(self._name, self._terminal_status, patch)
+    def did_pass(self, patch):
+        self._status.update_status(self._name, self._pass_status, patch)
+
+    def did_fail(self, patch):
+        self._status.update_status(self._name, self._fail_status, patch)