Changeset 51590 in webkit


Ignore:
Timestamp:
Dec 2, 2009 1:04:55 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-02 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

trim commands/*.py includes now that commands are unit tested
​https://bugs.webkit.org/show_bug.cgi?id=32056

In the course of ensuring that the unit tests still
passed after this change, I had to actually make them
pass in the first place.

  • Scripts/modules/bugzilla.py:
    • Fix _parse_attachment_ids_request_query to return ints instead of strings.
  • Scripts/modules/commands/download.py: Remove unneeded imports.
  • Scripts/modules/commands/queries.py: Ditto.
  • Scripts/modules/commands/queues.py: Ditto.
  • Scripts/modules/commands/upload.py: Ditto.
  • Scripts/modules/scm_unittest.py:
    • Fix to expect the \n after the path since echo adds an \n.
Location:
trunk/WebKitTools
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r51585 r51590  
     12009-12-02  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        trim commands/*.py includes now that commands are unit tested
     6        https://bugs.webkit.org/show_bug.cgi?id=32056
     7
     8        In the course of ensuring that the unit tests still
     9        passed after this change, I had to actually make them
     10        pass in the first place.
     11
     12        * Scripts/modules/bugzilla.py:
     13         - Fix _parse_attachment_ids_request_query to return ints instead of strings.
     14        * Scripts/modules/commands/download.py: Remove unneeded imports.
     15        * Scripts/modules/commands/queries.py: Ditto.
     16        * Scripts/modules/commands/queues.py: Ditto.
     17        * Scripts/modules/commands/upload.py: Ditto.
     18        * Scripts/modules/scm_unittest.py:
     19         - Fix to expect the \n after the path since echo adds an \n.
     20
    1212009-12-01  Yaar Schnitman  <yaar@chromium.org>
    222

  • trunk/WebKitTools/Scripts/bugzilla-tool

    r51450 r51590  
    3333import os
    3434
     35from modules.bugzilla import Bugzilla
     36from modules.buildbot import BuildBot
    3537from modules.buildsteps import BuildSteps
    3638from modules.commands.download import *
    … …  
    3941from modules.commands.upload import *
    4042from modules.logging import log
     43from modules.multicommandtool import MultiCommandTool
     44from modules.scm import detect_scm_system
    4145
    4246class BugzillaTool(MultiCommandTool):

  • trunk/WebKitTools/Scripts/modules/bugzilla.py

    r51464 r51590  
    314314        attachment_href = re.compile("attachment.cgi\?id=\d+&action=review")
    315315        attachment_links = SoupStrainer("a", href=attachment_href)
    316         return [digits.search(tag["href"]).group(0) for tag in BeautifulSoup(page, parseOnlyThese=attachment_links)]
     316        return [int(digits.search(tag["href"]).group(0)) for tag in BeautifulSoup(page, parseOnlyThese=attachment_links)]
    317317
    318318    def _fetch_attachment_ids_request_query(self, query):

  • trunk/WebKitTools/Scripts/modules/commands/download.py

    r51443 r51590  
    2929# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    3030
    31 # FIXME: Trim down this import list once we have unit tests.
    3231import os
    33 import re
    34 import StringIO
    35 import subprocess
    36 import sys
    37 import time
    38 
    39 from datetime import datetime, timedelta
     32
    4033from optparse import make_option
    4134
    42 from modules.bugzilla import Bugzilla, parse_bug_id
    43 from modules.buildbot import BuildBot
     35from modules.bugzilla import parse_bug_id
    4436from modules.buildsteps import BuildSteps
    4537from modules.changelogs import ChangeLog
    … …  
    4739from modules.grammar import pluralize
    4840from modules.landingsequence import LandingSequence, ConditionalLandingSequence
    49 from modules.logging import error, log, tee
    50 from modules.multicommandtool import MultiCommandTool, Command
    51 from modules.patchcollection import PatchCollection
    52 from modules.scm import CommitMessage, detect_scm_system, ScriptError, CheckoutNeedsUpdate
    53 from modules.statusbot import StatusBot
    54 from modules.webkitport import WebKitPort
    55 from modules.workqueue import WorkQueue, WorkQueueDelegate
     41from modules.logging import error, log
     42from modules.multicommandtool import Command
     43from modules.scm import ScriptError
    5644
    5745

  • trunk/WebKitTools/Scripts/modules/commands/queries.py

    r51464 r51590  
    2929# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    3030
    31 # FIXME: Trim down this import list once we have unit tests.
    32 import os
    33 import re
    34 import StringIO
    35 import subprocess
    36 import sys
    37 import time
    3831
    39 from datetime import datetime, timedelta
    4032from optparse import make_option
    4133
    42 from modules.bugzilla import Bugzilla, parse_bug_id
    4334from modules.buildbot import BuildBot
    44 from modules.changelogs import ChangeLog
    45 from modules.comments import bug_comment_from_commit_text
    46 from modules.grammar import pluralize
    47 from modules.landingsequence import LandingSequence, ConditionalLandingSequence
    48 from modules.logging import error, log, tee
    49 from modules.multicommandtool import MultiCommandTool, Command
    50 from modules.patchcollection import PatchCollection
    51 from modules.scm import CommitMessage, detect_scm_system, ScriptError, CheckoutNeedsUpdate
    52 from modules.statusbot import StatusBot
    53 from modules.webkitport import WebKitPort
    54 from modules.workqueue import WorkQueue, WorkQueueDelegate
     35from modules.logging import log
     36from modules.multicommandtool import Command
    5537
    5638class BugsToCommit(Command):

  • trunk/WebKitTools/Scripts/modules/commands/queues.py

    r51518 r51590  
    2929# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    3030
    31 # FIXME: Trim down this import list once we have unit tests.
    32 import os
    3331import re
    34 import StringIO
    35 import subprocess
    36 import sys
    37 import time
    38 
    39 from datetime import datetime, timedelta
     32
     33from datetime import datetime
    4034from optparse import make_option
    4135
    42 from modules.bugzilla import Bugzilla, parse_bug_id
    43 from modules.buildbot import BuildBot
    44 from modules.changelogs import ChangeLog
    45 from modules.comments import bug_comment_from_commit_text
    4636from modules.grammar import pluralize
    4737from modules.landingsequence import LandingSequence, ConditionalLandingSequence, LandingSequenceErrorHandler
    48 from modules.logging import error, log, tee
    49 from modules.multicommandtool import MultiCommandTool, Command
     38from modules.logging import error, log
     39from modules.multicommandtool import Command
    5040from modules.patchcollection import PatchCollection, PersistentPatchCollection, PersistentPatchCollectionDelegate
    5141from modules.processutils import run_and_throw_if_fail
    52 from modules.scm import CommitMessage, detect_scm_system, ScriptError, CheckoutNeedsUpdate
     42from modules.scm import ScriptError
    5343from modules.statusbot import StatusBot
    5444from modules.webkitport import WebKitPort

  • trunk/WebKitTools/Scripts/modules/commands/upload.py

    r51437 r51590  
    2929# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    3030
    31 # FIXME: Trim down this import list once we have unit tests.
    3231import os
    33 import re
    3432import StringIO
    35 import subprocess
    3633import sys
    37 import time
    38 
    39 from datetime import datetime, timedelta
     34
    4035from optparse import make_option
    4136
    42 from modules.bugzilla import Bugzilla, parse_bug_id
    43 from modules.buildbot import BuildBot
    44 from modules.changelogs import ChangeLog
    45 from modules.comments import bug_comment_from_commit_text
     37from modules.bugzilla import parse_bug_id
    4638from modules.grammar import pluralize
    47 from modules.landingsequence import LandingSequence, ConditionalLandingSequence
    48 from modules.logging import error, log, tee
    49 from modules.multicommandtool import MultiCommandTool, Command
    50 from modules.patchcollection import PatchCollection
    51 from modules.scm import CommitMessage, detect_scm_system, ScriptError, CheckoutNeedsUpdate
    52 from modules.statusbot import StatusBot
    53 from modules.webkitport import WebKitPort
    54 from modules.workqueue import WorkQueue, WorkQueueDelegate
     39from modules.logging import error, log
     40from modules.multicommandtool import Command
    5541
    5642# FIXME: Requires unit test.

  • trunk/WebKitTools/Scripts/modules/scm_unittest.py

    r51417 r51590  
    404404        os.makedirs(scripts_path)
    405405        create_patch_path = os.path.join(scripts_path, 'svn-create-patch')
    406         write_into_file_at_path(create_patch_path, '#!/bin/sh\necho $PWD')
     406        write_into_file_at_path(create_patch_path, '#!/bin/sh\necho $PWD') # We could pass -n to prevent the \n, but not all echo accept -n.
    407407        os.chmod(create_patch_path, stat.S_IXUSR | stat.S_IRUSR)
    408408
    … …  
    413413        patch_contents = scm.create_patch()
    414414        # Our fake 'svn-create-patch' returns $PWD instead of a patch, check that it was executed from the root of the repo.
    415         self.assertEqual(os.path.realpath(scm.checkout_root), patch_contents)
     415        self.assertEqual("%s\n" % os.path.realpath(scm.checkout_root), patch_contents) # Add a \n because echo adds a \n.
    416416
    417417    def test_detection(self):
Note: See TracChangeset for help on using the changeset viewer.