Changeset 51596 in webkit


Ignore:
Timestamp:
Dec 2, 2009 2:51:20 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] build-attachment shouldn't check whether the builders are red
​https://bugs.webkit.org/show_bug.cgi?id=32062

build-attachment doesn't touch the remote repository, so there isn't a
need to hold off when the builders are red.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r51595 r51596  
     12009-12-02  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [bzt] build-attachment shouldn't check whether the builders are red
     6        https://bugs.webkit.org/show_bug.cgi?id=32062
     7
     8        build-attachment doesn't touch the remote repository, so there isn't a
     9        need to hold off when the builders are red.
     10
     11        * Scripts/modules/commands/download.py:
     12        * Scripts/modules/landingsequence.py:
     13
    1142009-12-02  Eric Seidel  <eric@webkit.org>
    215

  • trunk/WebKitTools/Scripts/modules/commands/download.py

    r51593 r51596  
    130130
    131131    def run(self):
     132        self.check_builders()
    132133        self.build()
    133134        self.test()

  • trunk/WebKitTools/Scripts/modules/landingsequence.py

    r51460 r51596  
    5252        self.update()
    5353        self.apply_patch()
     54        self.check_builders()
    5455        self.build()
    5556        self.test()
    … …  
    8384        self._tool.scm().apply_patch(self._patch, force=self._options.non_interactive)
    8485
     86    def check_builders(self):
     87        self._tool.steps.ensure_builders_are_green(self._tool.buildbot, self._options)
     88
    8589    def build(self):
    86         # Make sure the tree is still green after updating, before building this patch.
    87         # The first patch ends up checking tree status twice, but that's OK.
    88         self._tool.steps.ensure_builders_are_green(self._tool.buildbot, self._options)
    8990        self._tool.steps.build_webkit(quiet=self._options.quiet, port=self._port)
    9091
    … …  
    121122            LandingSequence.update(self)
    122123
     124    def check_builders(self):
     125        if self._options.build:
     126            LandingSequence.check_builders(self)
     127
    123128    def build(self):
    124129        if self._options.build:
Note: See TracChangeset for help on using the changeset viewer.