Changeset 51630 in webkit
- Timestamp:
- Dec 3, 2009 4:31:28 AM (14 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r51629 r51630 1 2009-12-03 Ben Murdoch <benm@google.com> 2 3 Reviewed by Brady Eidson. 4 5 [Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed. 6 https://bugs.webkit.org/show_bug.cgi?id=31915 7 8 No change in functionality so no new tests required. 9 10 * history/HistoryItem.cpp: 11 (WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed. 12 (WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter. 13 (WebCore::HistoryItem::setURLString): ditto. 14 (WebCore::HistoryItem::setOriginalURLString): ditto. 15 (WebCore::HistoryItem::setReferrer): ditto. 16 (WebCore::HistoryItem::setTitle): ditto. 17 (WebCore::HistoryItem::setTarget): ditto. 18 (WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed. 19 (WebCore::HistoryItem::clearDocumentState): ditto. 20 (WebCore::HistoryItem::setIsTargetItem): ditto. 21 (WebCore::HistoryItem::addChildItem): ditto. 22 (WebCore::HistoryItem::setFormInfoFromRequest): ditto. 23 * history/HistoryItem.h: Update signature of notifyHistoryItemChanged. 24 1 25 2009-12-03 Ben Murdoch <benm@google.com> 2 26 -
trunk/WebCore/history/HistoryItem.cpp
r47907 r51630 37 37 namespace WebCore { 38 38 39 static void defaultNotifyHistoryItemChanged( )40 { 41 } 42 43 void (*notifyHistoryItemChanged)( ) = defaultNotifyHistoryItemChanged;39 static void defaultNotifyHistoryItemChanged(HistoryItem*) 40 { 41 } 42 43 void (*notifyHistoryItemChanged)(HistoryItem*) = defaultNotifyHistoryItemChanged; 44 44 45 45 HistoryItem::HistoryItem() … … 199 199 { 200 200 m_displayTitle = alternateTitle; 201 notifyHistoryItemChanged( );201 notifyHistoryItemChanged(this); 202 202 } 203 203 … … 210 210 } 211 211 212 notifyHistoryItemChanged( );212 notifyHistoryItemChanged(this); 213 213 } 214 214 … … 223 223 { 224 224 m_originalURLString = urlString; 225 notifyHistoryItemChanged( );225 notifyHistoryItemChanged(this); 226 226 } 227 227 … … 229 229 { 230 230 m_referrer = referrer; 231 notifyHistoryItemChanged( );231 notifyHistoryItemChanged(this); 232 232 } 233 233 … … 235 235 { 236 236 m_title = title; 237 notifyHistoryItemChanged( );237 notifyHistoryItemChanged(this); 238 238 } 239 239 … … 241 241 { 242 242 m_target = target; 243 notifyHistoryItemChanged( );243 notifyHistoryItemChanged(this); 244 244 } 245 245 … … 357 357 { 358 358 m_documentState = state; 359 #if PLATFORM(ANDROID) 360 notifyHistoryItemChanged(this); 361 #endif 359 362 } 360 363 … … 367 370 { 368 371 m_documentState.clear(); 372 #if PLATFORM(ANDROID) 373 notifyHistoryItemChanged(this); 374 #endif 369 375 } 370 376 … … 377 383 { 378 384 m_isTargetItem = flag; 385 #if PLATFORM(ANDROID) 386 notifyHistoryItemChanged(this); 387 #endif 379 388 } 380 389 … … 383 392 ASSERT(!childItemWithTarget(child->target())); 384 393 m_children.append(child); 394 #if PLATFORM(ANDROID) 395 notifyHistoryItemChanged(this); 396 #endif 385 397 } 386 398 … … 461 473 m_formContentType = String(); 462 474 } 475 #if PLATFORM(ANDROID) 476 notifyHistoryItemChanged(this); 477 #endif 463 478 } 464 479 -
trunk/WebCore/history/HistoryItem.h
r51628 r51630 59 59 typedef Vector<RefPtr<HistoryItem> > HistoryItemVector; 60 60 61 extern void (*notifyHistoryItemChanged)( );61 extern void (*notifyHistoryItemChanged)(HistoryItem*); 62 62 63 63 enum VisitCountBehavior { -
trunk/WebKit/mac/ChangeLog
r51629 r51630 1 2009-12-03 Ben Murdoch <benm@google.com> 2 3 Reviewed by Brady Eidson. 4 5 [Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed. 6 https://bugs.webkit.org/show_bug.cgi?id=31915 7 8 * History/WebHistoryItem.mm: 9 (WKNotifyHistoryItemChanged): Update WKNotifyHistoryItemChanged() to add the new HistoryItem parameter added in the WebCore portion of this patch. 10 * History/WebHistoryItemInternal.h: ditto. 11 1 12 2009-12-03 Ben Murdoch <benm@google.com> 2 13 -
trunk/WebKit/mac/History/WebHistoryItem.mm
r45675 r51630 85 85 } 86 86 87 void WKNotifyHistoryItemChanged( )87 void WKNotifyHistoryItemChanged(HistoryItem*) 88 88 { 89 89 [[NSNotificationCenter defaultCenter] -
trunk/WebKit/mac/History/WebHistoryItemInternal.h
r45675 r51630 38 38 WebHistoryItem *kit(WebCore::HistoryItem* item); 39 39 40 extern void WKNotifyHistoryItemChanged( );40 extern void WKNotifyHistoryItemChanged(WebCore::HistoryItem*); 41 41 42 42 @interface WebHistoryItem (WebInternal)
Note: See TracChangeset
for help on using the changeset viewer.