Changeset 51680 in webkit


Ignore:
Timestamp:
Dec 3, 2009 10:19:58 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

OwnPtr<XBLBindingManager> Document::m_bindingManager;
https://bugs.webkit.org/show_bug.cgi?id=32147

The document actually owns the bindingManager. That's what the code
should say.

  • dom/Document.cpp: (WebCore::Document::~Document):
  • dom/Document.h: (WebCore::Document::bindingManager):
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r51679 r51680  
     12009-12-03  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        OwnPtr<XBLBindingManager> Document::m_bindingManager;
     6        https://bugs.webkit.org/show_bug.cgi?id=32147
     7
     8        The document actually owns the bindingManager.  That's what the code
     9        should say.
     10
     11        * dom/Document.cpp:
     12        (WebCore::Document::~Document):
     13        * dom/Document.h:
     14        (WebCore::Document::bindingManager):
     15
    1162009-12-03  Adam Barth  <abarth@webkit.org>
    217
  • trunk/WebCore/dom/Document.cpp

    r51679 r51680  
    488488
    489489#if ENABLE(XBL)
    490     delete m_bindingManager;
     490    m_bindingManager.clear();
    491491#endif
    492492
  • trunk/WebCore/dom/Document.h

    r51679 r51680  
    767767#if ENABLE(XBL)
    768768    // XBL methods
    769     XBLBindingManager* bindingManager() const { return m_bindingManager; }
     769    XBLBindingManager* bindingManager() const { return m_bindingManager.get(); }
    770770#endif
    771771
     
    10891089
    10901090#if ENABLE(XBL)
    1091     XBLBindingManager* m_bindingManager; // The access point through which documents and elements communicate with XBL.
     1091    OwnPtr<XBLBindingManager> m_bindingManager; // The access point through which documents and elements communicate with XBL.
    10921092#endif
    10931093   
Note: See TracChangeset for help on using the changeset viewer.