Changeset 51724 in webkit

Timestamp:

Dec 4, 2009 5:21:45 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-04 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

JavaScript delete operator should return false for string properties
​https://bugs.webkit.org/show_bug.cgi?id=32012

• runtime/StringObject.cpp: (JSC::StringObject::deleteProperty):

2009-12-04 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Darin Adler.

Add test for JavaScript string property deletion
​https://bugs.webkit.org/show_bug.cgi?id=32012

• fast/js/script-tests/string-property-deletion.js: Added.
• fast/js/string-property-deletion-expected.txt: Added.
• fast/js/string-property-deletion.html: Added.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/StringObject.cpp (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/script-tests/string-property-deletion.js (added)
• LayoutTests/fast/js/string-property-deletion-expected.txt (added)
• LayoutTests/fast/js/string-property-deletion.html (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2009-12-04  Kent Hansen  <kent.hansen@nokia.com>
+
+        Reviewed by Darin Adler.
+
+        JavaScript delete operator should return false for string properties
+        https://bugs.webkit.org/show_bug.cgi?id=32012
+
+        * runtime/StringObject.cpp:
+        (JSC::StringObject::deleteProperty):
+
 2009-12-03  Drew Wilson  <atwilson@chromium.org>
 

trunk/JavaScriptCore/runtime/StringObject.cpp

@@ -80 +80 @@
     if (propertyName == exec->propertyNames().length)
         return false;
+    bool isStrictUInt32;
+    unsigned i = propertyName.toStrictUInt32(&isStrictUInt32);
+    if (isStrictUInt32 && internalValue()->canGetIndex(i))
+        return false;
     return JSObject::deleteProperty(exec, propertyName);
 }

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-12-04  Kent Hansen  <kent.hansen@nokia.com>
+
+        Reviewed by Darin Adler.
+
+        Add test for JavaScript string property deletion
+        https://bugs.webkit.org/show_bug.cgi?id=32012
+
+        * fast/js/script-tests/string-property-deletion.js: Added.
+        * fast/js/string-property-deletion-expected.txt: Added.
+        * fast/js/string-property-deletion.html: Added.
+
 2009-12-04  Yuzo Fujishima  <yuzo@google.com>