Changeset 51730 in webkit

Timestamp:

Dec 5, 2009 1:55:12 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-12-05 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement ChromiumPort
​https://bugs.webkit.org/show_bug.cgi?id=32182

• Scripts/modules/webkitport.py:
• Scripts/modules/webkitport_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/webkitport.py (modified) (2 diffs)
• Scripts/modules/webkitport_unittest.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-05  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] Implement ChromiumPort
+        https://bugs.webkit.org/show_bug.cgi?id=32182
+
+        * Scripts/modules/webkitport.py:
+        * Scripts/modules/webkitport_unittest.py:
+
 2009-12-05  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/modules/webkitport.py

@@ -51 +51 @@
         if options.port == "qt":
             return QtPort
+        if options.port == "chromium":
+            return ChromiumPort
         # FIXME: We should default to WinPort on Windows.
         return MacPort
@@ -99 +101 @@
         command.append("--qt")
         return command
+
+
+class ChromiumPort(WebKitPort):
+    @classmethod
+    def name(cls):
+        return "Chromium"
+
+    @classmethod
+    def flag(cls):
+        return "--port=chromium"
+
+    @classmethod
+    def update_webkit_command(cls):
+        command = WebKitPort.update_webkit_command()
+        command.append("--chromium")
+        return command
+
+    @classmethod
+    def build_webkit_command(cls):
+        command = WebKitPort.build_webkit_command()
+        command.append("--chromium")
+        return command

trunk/WebKitTools/Scripts/modules/webkitport_unittest.py

@@ -30 +30 @@
 import unittest
 
-from modules.webkitport import WebKitPort, MacPort, QtPort
+from modules.webkitport import WebKitPort, MacPort, QtPort, ChromiumPort
 
 class WebKitPortTest(unittest.TestCase):
@@ -45 +45 @@
         self.assertEquals(QtPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--qt"])
 
+    def test_chromium_port(self):
+        self.assertEquals(ChromiumPort.name(), "Chromium")
+        self.assertEquals(ChromiumPort.flag(), "--port=chromium")
+        self.assertEquals(ChromiumPort.run_webkit_tests_command(), [WebKitPort.script_path("run-webkit-tests")])
+        self.assertEquals(ChromiumPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--chromium"])
+        self.assertEquals(ChromiumPort.update_webkit_command(), [WebKitPort.script_path("update-webkit"), "--chromium"])
+
 
 if __name__ == '__main__':