Changeset 51764 in webkit


Ignore:
Timestamp:
Dec 7, 2009 6:35:30 AM (14 years ago)
Author:
kov@webkit.org
Message:

Reviewed by Xan Lopez.

Build the new API test.

[GTK] REGRESSION: webkit thinks it can render PDFs
​https://bugs.webkit.org/show_bug.cgi?id=32183

  • GNUmakefile.am:

WebCore

Reviewed by Xan Lopez.

Turn the MediaPlayer supported types blacklist into a whitelist

[GTK] REGRESSION: webkit thinks it can render PDFs
​https://bugs.webkit.org/show_bug.cgi?id=32183

Covered by API test.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

WebKit/gtk

Reviewed by Xan Lopez.

New test to make sure we do not regress this feature anymore. All
test files were created by me.

[GTK] REGRESSION: webkit thinks it can render PDFs
​https://bugs.webkit.org/show_bug.cgi?id=32183

  • tests/resources/test.html: Added.
  • tests/resources/test.ogg: Added.
  • tests/resources/test.pdf: Added.
  • tests/resources/test.txt: Added.
  • tests/testmimehandling.c: Added. (server_callback): (idle_quit_loop_cb): (mime_type_policy_decision_requested_cb): (test_mime_type): (test_mime_pdf): (test_mime_html): (test_mime_text): (test_mime_ogg): (main):
Location:
trunk
Files:
6 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r51725 r51764  
     12009-12-06  Gustavo Noronha Silva  <gns@gnome.org>
     2
     3        Reviewed by Xan Lopez.
     4
     5        Build the new API test.
     6
     7        [GTK] REGRESSION: webkit thinks it can render PDFs
     8        https://bugs.webkit.org/show_bug.cgi?id=32183
     9
     10        * GNUmakefile.am:
     11
    1122009-12-05  Vincent Untz <vuntz@gnome.org>
    213

  • trunk/GNUmakefile.am

    r51725 r51764  
    583583TEST_PROGS += Programs/unittests/testhttpbackend \
    584584        Programs/unittests/testloading \
     585        Programs/unittests/testmimehandling \
    585586        Programs/unittests/testnetworkrequest \
    586587        Programs/unittests/testnetworkresponse \
    … …  
    607608Programs_unittests_testloading_LDADD = $(webkit_tests_ldadd)
    608609Programs_unittests_testloading_LDFLAGS = $(webkit_tests_ldflags)
     610
     611Programs_unittests_testmimehandling_SOURCES = WebKit/gtk/tests/testmimehandling.c
     612Programs_unittests_testmimehandling_CFLAGS = $(webkit_tests_cflags)
     613Programs_unittests_testmimehandling_LDADD = $(webkit_tests_ldadd)
     614Programs_unittests_testmimehandling_LDFLAGS = $(webkit_tests_ldflags)
    609615
    610616Programs_unittests_testnetworkrequest_SOURCES = WebKit/gtk/tests/testnetworkrequest.c

  • trunk/WebCore/ChangeLog

    r51762 r51764  
     12009-12-07  Gustavo Noronha Silva  <gns@gnome.org>
     2
     3        Reviewed by Xan Lopez.
     4
     5        Turn the MediaPlayer supported types blacklist into a whitelist
     6
     7        [GTK] REGRESSION: webkit thinks it can render PDFs
     8        https://bugs.webkit.org/show_bug.cgi?id=32183
     9
     10        Covered by API test.
     11
     12        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
     13        (WebCore::mimeTypeCache):
     14
    1152009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
    216

  • trunk/WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp

    r51734 r51764  
    759759    if (!typeListInitialized) {
    760760        // These subtypes are already beeing supported by WebKit itself
    761         HashSet<String> ignoredApplicationSubtypes;
    762         ignoredApplicationSubtypes.add(String("javascript"));
    763         ignoredApplicationSubtypes.add(String("ecmascript"));
    764         ignoredApplicationSubtypes.add(String("x-javascript"));
    765         ignoredApplicationSubtypes.add(String("xml"));
    766         ignoredApplicationSubtypes.add(String("xhtml+xml"));
    767         ignoredApplicationSubtypes.add(String("rss+xml"));
    768         ignoredApplicationSubtypes.add(String("atom+xml"));
    769         ignoredApplicationSubtypes.add(String("x-ftp-directory"));
    770         ignoredApplicationSubtypes.add(String("x-java-applet"));
    771         ignoredApplicationSubtypes.add(String("x-java-bean"));
    772         ignoredApplicationSubtypes.add(String("x-java-vm"));
    773         ignoredApplicationSubtypes.add(String("x-shockwave-flash"));
     761        HashSet<String> handledApplicationSubtypes;
     762        handledApplicationSubtypes.add(String("x-id3v2"));
     763        handledApplicationSubtypes.add(String("x-id3v1"));
     764        handledApplicationSubtypes.add(String("x-apetag"));
     765        handledApplicationSubtypes.add(String("ogg"));
     766        handledApplicationSubtypes.add(String("x-3gp"));
     767        handledApplicationSubtypes.add(String("vnd.rn-realmedia"));
     768        handledApplicationSubtypes.add(String("x-pn-realaudio"));
     769        handledApplicationSubtypes.add(String("sdp"));
     770        handledApplicationSubtypes.add(String("smil"));
    774771
    775772        GList* factories = gst_type_find_factory_get_list();
    … …  
    844841                        || g_str_equal(mimetype[0], "video")
    845842                        || (g_str_equal(mimetype[0], "application")
    846                             && !ignoredApplicationSubtypes.contains(String(mimetype[1]))))
     843                            && handledApplicationSubtypes.contains(String(mimetype[1]))))
    847844                        cache.add(String(name));
    848845

  • trunk/WebKit/gtk/ChangeLog

    r51726 r51764  
     12009-12-06  Gustavo Noronha Silva  <gns@gnome.org>
     2
     3        Reviewed by Xan Lopez.
     4
     5        New test to make sure we do not regress this feature anymore. All
     6        test files were created by me.
     7
     8        [GTK] REGRESSION: webkit thinks it can render PDFs
     9        https://bugs.webkit.org/show_bug.cgi?id=32183
     10
     11        * tests/resources/test.html: Added.
     12        * tests/resources/test.ogg: Added.
     13        * tests/resources/test.pdf: Added.
     14        * tests/resources/test.txt: Added.
     15        * tests/testmimehandling.c: Added.
     16        (server_callback):
     17        (idle_quit_loop_cb):
     18        (mime_type_policy_decision_requested_cb):
     19        (test_mime_type):
     20        (test_mime_pdf):
     21        (test_mime_html):
     22        (test_mime_text):
     23        (test_mime_ogg):
     24        (main):
     25
    1262009-12-05  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
    227
Note: See TracChangeset for help on using the changeset viewer.