Changeset 51790 in webkit

Timestamp:

Dec 7, 2009 1:05:39 PM (14 years ago)

Author:

ap@apple.com

Message:

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=32226
Random crashes in WebSocket tests on Leopard Debug builbot

• platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close): Make sure the object still exists when setting m_state.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/SocketStreamHandleBase.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-07  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Nikolas Zimmermann.
+
+        https://bugs.webkit.org/show_bug.cgi?id=32226
+        Random crashes in WebSocket tests on Leopard Debug builbot
+
+        * platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close):
+        Make sure the object still exists when setting m_state.
+
 2009-12-07  Shiki Okasaka  <shiki@google.com>
 

trunk/WebCore/platform/network/SocketStreamHandleBase.cpp

@@ -32 +32 @@
 #include "SocketStreamHandleBase.h"
 
+#include "SocketStreamHandle.h"
 #include "SocketStreamHandleClient.h"
 
@@ -78 +79 @@
 void SocketStreamHandleBase::close()
 {
+    RefPtr<SocketStreamHandle> protect(static_cast<SocketStreamHandle*>(this)); // platformClose calls the client, which may make the handle get deallocated immediately.
+
     platformClose();
     m_state = Closed;