Changeset 51923 in webkit

Timestamp:

Dec 9, 2009 2:25:35 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

exception thrown when running apply-patches
​https://bugs.webkit.org/show_bug.cgi?id=32344

The update step now takes a port option. Once we finish the Steps
refactoring, we won't have to worry about this kind of bug again.

• Scripts/modules/commands/download.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/commands/download.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-09  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        exception thrown when running apply-patches
+        https://bugs.webkit.org/show_bug.cgi?id=32344
+
+        The update step now takes a port option.  Once we finish the Steps
+        refactoring, we won't have to worry about this kind of bug again.
+
+        * Scripts/modules/commands/download.py:
+
 2009-12-09  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/modules/commands/download.py

@@ -34 +34 @@
 
 from modules.bugzilla import parse_bug_id
-from modules.buildsteps import BuildSteps, EnsureBuildersAreGreenStep, CleanWorkingDirectoryStep, UpdateStep, BuildStep, CheckStyleStep, PrepareChangelogStep
+from modules.buildsteps import CommandOptions, BuildSteps, EnsureBuildersAreGreenStep, CleanWorkingDirectoryStep, UpdateStep, BuildStep, CheckStyleStep, PrepareChangelogStep
 from modules.changelogs import ChangeLog
 from modules.comments import bug_comment_from_commit_text
@@ -96 +96 @@
             make_option("--no-update", action="store_false", dest="update", default=True, help="Don't update the working directory before applying patches"),
             make_option("--local-commit", action="store_true", dest="local_commit", default=False, help="Make a local commit for each applied patch"),
+            CommandOptions.port,
         ]