Changeset 51929 in webkit

Timestamp:

Dec 9, 2009 3:08:44 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-09 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Added the "using std::foo" rule to the coding style guidelines.

​https://bugs.webkit.org/show_bug.cgi?id=32301

Added to the coding style guidelines the "using std::foo" rule
checked by the check-webkit-style script. Also clarified the
"using" statement guidelines that apply to implementation files.

• coding/coding-style.html:

Location:

trunk/WebKitSite

Files:

• ChangeLog (modified) (1 diff)
• coding/coding-style.html (modified) (5 diffs)

trunk/WebKitSite/ChangeLog

@@ +1 @@
+2009-12-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
+
+        Reviewed by Darin Adler.
+
+        Added the "using std::foo" rule to the coding style guidelines.
+        
+        https://bugs.webkit.org/show_bug.cgi?id=32301
+        
+        Added to the coding style guidelines the "using std::foo" rule
+        checked by the check-webkit-style script.  Also clarified the
+        "using" statement guidelines that apply to implementation files.
+
+        * coding/coding-style.html:
+
 2009-12-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
 

trunk/WebKitSite/coding/coding-style.html

@@ -710 +710 @@
 <ol>
 
-<li>In header files, do not use "using" statements in global or 
-"namespace" scope.
+<li>In header files, do not use "using" statements in namespace
+(or global) scope.
 
 <h4 class="right">Right:</h4>
@@ -742 +742 @@
 </li>
 
-<li>It is acceptable, however, to use "using" declarations at the end of 
-header files in the WTF sub-library to include one or more names in 
-the WTF namespace into the global scope.
+<li>In header files in the WTF sub-library, however, it is acceptable
+to use "using" declarations at the end of the file to import one
+or more names in the WTF namespace into the global scope.
 
 <h4 class="right">Right:</h4>
@@ -778 +778 @@
 </li>
 
-<li>Any "using namespace" statements for a nested namespace whose parent namespace 
-is also defined in a file must be declared within that namespace definition.
+<li>In C++ implementation files, do not use statements of the form
+"using std::foo" to import names in the standard template library.
+Use "using namespace std" instead.
 
 <h4 class="right">Right:</h4>
@@ -785 +786 @@
 // HTMLBaseElement.cpp
 
+using namespace std;
+
+namespace WebCore {
+
+} // namespace WebCore
+</pre>
+
+<h4 class="wrong">Wrong:</h4>
+<pre class="code">
+// HTMLBaseElement.cpp
+
+using std::swap;
+
+namespace WebCore {
+
+} // namespace WebCore
+</pre>
+</li>
+
+<li>In implementation files, if a "using namespace" statement is
+for a nested namespace whose parent namespace is defined in the file,
+put the statement inside that namespace definition.
+
+<h4 class="right">Right:</h4>
+<pre class="code">
+// HTMLBaseElement.cpp
+
 namespace WebCore {
 
@@ -804 +832 @@
 </li>
 
-<li>Any other "using namespace" statements must be declared before the first namespace 
-definition in the file.
+<li>In implementation files, put all other "using" statements
+at the beginning of the file, before any namespace definitions and
+after any "include" statements.
+
 <h4 class="right">Right:</h4>
 <pre class="code">