Changeset 51940 in webkit

Timestamp:

Dec 10, 2009 12:18:05 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool "builders are red" error should tell you which builders
​https://bugs.webkit.org/show_bug.cgi?id=32211

• Scripts/modules/buildsteps.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/buildsteps.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-10  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        bugzilla-tool "builders are red" error should tell you which builders
+        https://bugs.webkit.org/show_bug.cgi?id=32211
+
+        * Scripts/modules/buildsteps.py:
+
 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
 

trunk/WebKitTools/Scripts/modules/buildsteps.py

@@ -138 +138 @@
         if not self._options.check_builders:
             return
-        if not self._tool.buildbot.core_builders_are_green():
-            error("Builders at %s are red, please do not commit.  Pass --ignore-builders to bypass this check." % (self._tool.buildbot.buildbot_host))
+        red_builders_names = self._tool.buildbot.red_core_builders_names()
+        if not red_builders_names:
+            return
+        red_builders_names = map(lambda name: "\"%s\"" % name, red_builders_names) # Add quotes around the names.
+        error("Builders [%s] are red, please do not commit.\nSee http://%s.\nPass --ignore-builders to bypass this check." % (", ".join(red_builders_names), self._tool.buildbot.buildbot_host))