Changeset 52016 in webkit

Timestamp:

Dec 11, 2009 12:50:47 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[check-webkit-style] False positive for tst_QWebFrame
​https://bugs.webkit.org/show_bug.cgi?id=32436

Add an exception for function names that start with "tst_". These are
used by the Qt unit testing framework.

• Scripts/modules/cpp_style.py:
• Scripts/modules/cpp_style_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/cpp_style.py (modified) (1 diff)
• Scripts/modules/cpp_style_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-11  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [check-webkit-style] False positive for tst_QWebFrame
+        https://bugs.webkit.org/show_bug.cgi?id=32436
+
+        Add an exception for function names that start with "tst_".  These are
+        used by the Qt unit testing framework.
+
+        * Scripts/modules/cpp_style.py:
+        * Scripts/modules/cpp_style_unittest.py:
+
 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
 

trunk/WebKitTools/Scripts/modules/cpp_style.py

@@ -2738 +2738 @@
             # Various exceptions to the rule: JavaScript op codes functions, const_iterator.
             if (not (filename.find('JavaScriptCore') >= 0 and modified_identifier.find('_op_') >= 0)
+                and not modified_identifier.startswith('tst_')
                 and not modified_identifier == "const_iterator"):
                 error(filename, line_number, 'readability/naming', 4, identifier + " is incorrectly named. Don't use underscores in your identifier names.")

trunk/WebKitTools/Scripts/modules/cpp_style_unittest.py

@@ -3704 +3704 @@
         self.assert_lint('void this_op_code(int var1, int var2)', 'this_op_code' + name_error_message)
 
+        # There is an exception for some unit tests that begin with "tst_".
+        self.assert_lint('void tst_QWebFrame::arrayObjectEnumerable(int var1, int var2)', '')
+
         # const_iterator is allowed as well.
         self.assert_lint('typedef VectorType::const_iterator const_iterator;', '')