Changeset 52144 in webkit

Timestamp:

Dec 15, 2009 1:29:35 AM (14 years ago)

Author:

zecke@webkit.org

Message:

[Qt] Do not disable the inspector on show and hide

​https://bugs.webkit.org/show_bug.cgi?id=31851

On Qt/X11 with some window managers the window will be
hidden when switching windows. In this case all the results
are gone when coming back to the window.

Attempt to use the CloseEvent to figure out if the window
was closed and withdrawn as this is more friendly to the
user of the inspector client.

• Api/qwebinspector.cpp:

(QWebInspector::hideEvent):
(QWebInspector::closeEvent):

• Api/qwebinspector.h:

Location:

trunk/WebKit/qt

Files:

• Api/qwebinspector.cpp (modified) (1 diff)
• Api/qwebinspector.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/WebKit/qt/Api/qwebinspector.cpp

@@ -160 +160 @@
 void QWebInspector::hideEvent(QHideEvent* event)
 {
+}
+
+/*! \reimp */
+void QWebInspector::closeEvent(QCloseEvent* event)
+{
     if (d->page)
         d->page->d->inspectorController()->setWindowVisible(false);

trunk/WebKit/qt/Api/qwebinspector.h

@@ -44 +44 @@
     void showEvent(QShowEvent* event);
     void hideEvent(QHideEvent* event);
+    void closeEvent(QCloseEvent* event);
 
 private:

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2009-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Do not disable the inspector on show and hide
+        https://bugs.webkit.org/show_bug.cgi?id=31851
+
+        On Qt/X11 with some window managers the window will be
+        hidden when switching windows. In this case all the results
+        are gone when coming back to the window.
+
+        Attempt to use the CloseEvent to figure out if the window
+        was closed and withdrawn as this is more friendly to the
+        user of the inspector client.
+
+        * Api/qwebinspector.cpp:
+        (QWebInspector::hideEvent):
+        (QWebInspector::closeEvent):
+        * Api/qwebinspector.h:
+
 2009-12-14  Benjamin Poulain  <benjamin.poulain@nokia.com>