Changeset 52155 in webkit

Timestamp:

Dec 15, 2009 8:44:08 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-15 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter
​https://bugs.webkit.org/show_bug.cgi?id=32549

Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter
classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

AnimationControllerPrivate - page/animation/AnimationController.cpp:439
FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464

• page/animation/AnimationBase.cpp:
• page/animation/AnimationControllerPrivate.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/animation/AnimationBase.cpp (modified) (1 diff)
• page/animation/AnimationControllerPrivate.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-15  Zoltan Horvath  <zoltan@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter
+        https://bugs.webkit.org/show_bug.cgi?id=32549
+
+        Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter
+        classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:
+
+        class/struct name              - instantiated at: WebCore/'location'
+
+        AnimationControllerPrivate     - page/animation/AnimationController.cpp:439
+        FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464
+
+        * page/animation/AnimationBase.cpp:
+        * page/animation/AnimationControllerPrivate.h:
+
 2009-12-15  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/page/animation/AnimationBase.cpp

@@ -408 +408 @@
 
 template <typename T>
-class FillLayerPropertyWrapperGetter : public FillLayerPropertyWrapperBase {
+class FillLayerPropertyWrapperGetter : public FillLayerPropertyWrapperBase, public Noncopyable {
 public:
     FillLayerPropertyWrapperGetter(T (FillLayer::*getter)() const)

trunk/WebCore/page/animation/AnimationControllerPrivate.h

@@ -50 +50 @@
 class RenderStyle;
 
-class AnimationControllerPrivate {
+class AnimationControllerPrivate : public Noncopyable {
 public:
     AnimationControllerPrivate(Frame*);