Changeset 52185 in webkit

Timestamp:

Dec 15, 2009 6:26:21 PM (14 years ago)

Author:

mjs@apple.com

Message:

2009-12-15 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Make SunSpider refuse to compare results across content versions
​https://bugs.webkit.org/show_bug.cgi?id=32573

The results URL now includes a version indicator, and compare mode
will refuse to compare between versions.

• resources/driver-TEMPLATE.html:
• resources/results-TEMPLATE.html:

Location:

trunk/SunSpider

Files:

• ChangeLog (modified) (1 diff)
• resources/driver-TEMPLATE.html (modified) (1 diff)
• resources/results-TEMPLATE.html (modified) (2 diffs)

trunk/SunSpider/ChangeLog

@@ +1 @@
+2009-12-15  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Make SunSpider refuse to compare results across content versions
+        https://bugs.webkit.org/show_bug.cgi?id=32573
+        
+        The results URL now includes a version indicator, and compare mode
+        will refuse to compare between versions.
+
+        * resources/driver-TEMPLATE.html:
+        * resources/results-TEMPLATE.html:
+
 2009-12-14  Maciej Stachowiak  <mjs@apple.com>
 

trunk/SunSpider/resources/driver-TEMPLATE.html

@@ -92 +92 @@
 {
     var outputString = "{";
+    outputString += '"v": "@SUITE@", ';
     for (var test in output[0]) {
         outputString += '"' + test + '":[';

trunk/SunSpider/resources/results-TEMPLATE.html

@@ -56 +56 @@
 selfUrlInput.value = location;
 
-var output = pivot(JSON.parse(decodeURI(location.search.substring(1))));
+var outputJSON = JSON.parse(decodeURI(location.search.substring(1)));
+var version = outputJSON["v"];
+delete outputJSON["v"];
+var output = pivot(outputJSON);
 
 function pivot(input) {
@@ -83 +86 @@
 <script>
 var output2 = output;
+var version2 = version;
 
 function compare(other)
 {
     document.getElementById("console").innerHTML = "";
-    var output1 = pivot(JSON.parse(decodeURI(other.split("?")[1])));
-    sunspiderCompareResults(output1, output2);
+
+    var output1JSON = JSON.parse(decodeURI(other.split("?")[1]));
+    var version1 = output1JSON["v"];
+    delete output1JSON["v"];
+    if (version1 != version2) {
+        print("ERROR: cannot compare version " + version1 + ' with version ' + version2);
+    } else {
+        var output1 = pivot(output1JSON);
+        sunspiderCompareResults(output1, output2);
+    }
 }
 </script>