Changeset 52216 in webkit

Timestamp:

Dec 16, 2009 1:17:00 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add error handling to the early warning system
​https://bugs.webkit.org/show_bug.cgi?id=32594

This should be the last step in making the EWS operational. When we
have a build error, we post the log to QueueStatusServer and add a link
to the bug.

• Scripts/modules/commands/early_warning_system.py:
• Scripts/modules/commands/queues.py:
• Scripts/modules/executive.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/commands/early_warning_system.py (modified) (3 diffs)
• Scripts/modules/commands/queues.py (modified) (2 diffs)
• Scripts/modules/executive.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-16  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] Add error handling to the early warning system
+        https://bugs.webkit.org/show_bug.cgi?id=32594
+
+        This should be the last step in making the EWS operational.  When we
+        have a build error, we post the log to QueueStatusServer and add a link
+        to the bug.
+
+        * Scripts/modules/commands/early_warning_system.py:
+        * Scripts/modules/commands/queues.py:
+        * Scripts/modules/executive.py:
+
 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
 

trunk/WebKitTools/Scripts/modules/commands/early_warning_system.py

@@ -28 +28 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+from StringIO import StringIO
+
 from modules.commands.queues import AbstractReviewQueue
 from modules.executive import ScriptError
 from modules.webkitport import WebKitPort
+
 
 class AbstractEarlyWarningSystem(AbstractReviewQueue):
@@ -41 +44 @@
             self.run_bugzilla_tool(["build", self.port.flag(), "--force-clean", "--quiet"])
         except ScriptError, e:
-            return (False, "Unable to perform a build.", None)
-        return (True, "Building patch %s on bug %s." % (patch["id"], patch["bug_id"]), patch)
+            self._update_status("Unable to perform a build.")
+            return False
+        self._update_status("Building patch %s on bug %s." % (patch["id"], patch["bug_id"]), patch)
+        return True
 
     def process_work_item(self, patch):
@@ -56 +61 @@
         self._patches.did_pass(patch)
 
+    @classmethod
+    def handle_script_error(cls, tool, state, script_error):
+        # FIXME: This won't be right for ports that don't use build-webkit!
+        if not script_error.command_name() == "build-webkit":
+            return
+        patch = state["patch"]
+        status_id = tool.status_bot.update_status(cls.name, "patch %s failed: %s" % (patch["id"], script_error.message), patch, StringIO(script_error.output))
+        results_link = tool.status_bot.results_url_for_status(status_id)
+        message = "Attachment %s did not build on %s:\nFull output: %s" % (patch["id"], cls.port_name, results_link)
+        tool.bugs.post_comment_to_bug(patch["bug_id"], message, cc=cls.watchers)
+
 
 class QtEWS(AbstractEarlyWarningSystem):

trunk/WebKitTools/Scripts/modules/commands/queues.py

@@ -30 +30 @@
 
 import os
-import re
 
 from datetime import datetime
@@ -223 +222 @@
     @classmethod
     def handle_script_error(cls, tool, state, script_error):
-        command = script_error.script_args
-        if type(command) is list:
-            command = command[0]
-        # FIXME: We shouldn't need to use a regexp here.  ScriptError should
-        #        have a better API.
-        if re.search("check-webkit-style", command):
-            message = "Attachment %s did not pass %s:\n\n%s" % (state["patch"]["id"], cls.name, script_error.message_with_output(output_limit=5*1024))
-            tool.bugs.post_comment_to_bug(state["patch"]["bug_id"], message, cc=cls.watchers)
+        if not script_error.command_name() == "check-webkit-style":
+            return
+        message = "Attachment %s did not pass %s:\n\n%s" % (state["patch"]["id"], cls.name, script_error.message_with_output(output_limit=5*1024))
+        tool.bugs.post_comment_to_bug(state["patch"]["bug_id"], message, cc=cls.watchers)

trunk/WebKitTools/Scripts/modules/executive.py

@@ -57 +57 @@
             return "%s\n%s" % (self, self.output)
         return str(self)
+
+    def command_name(self):
+        command_path = self.script_args
+        if type(command_path) is list:
+            command_path = command_path[0]
+        return os.path.basename(command_path)