Changeset 52240 in webkit
- Timestamp:
- Dec 16, 2009 11:41:11 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r52239 r52240 1 2009-12-16 Evan Martin <evan@chromium.org> 2 3 Reviewed by Adam Barth. 4 5 Add Gtk to the early warning system WebKit port list. 6 7 https://bugs.webkit.org/show_bug.cgi?id=32629 8 9 * Scripts/modules/commands/early_warning_system.py: 10 * Scripts/modules/webkitport.py: 11 * Scripts/modules/webkitport_unittest.py: 12 1 13 2009-12-16 Eric Seidel <eric@webkit.org> 2 14 -
trunk/WebKitTools/Scripts/modules/commands/early_warning_system.py
r52216 r52240 73 73 74 74 75 class GtkEWS(AbstractEarlyWarningSystem): 76 name = "gtk-ews" 77 port_name = "gtk" 78 79 75 80 class QtEWS(AbstractEarlyWarningSystem): 76 81 name = "qt-ews" -
trunk/WebKitTools/Scripts/modules/webkitport.py
r51889 r52240 41 41 @staticmethod 42 42 def port(port_name): 43 if port_name == "mac":44 return MacPort45 if port_name == "qt":46 return QtPort47 if port_name == "chromium":48 return ChromiumPort43 ports = { 44 "chromium": ChromiumPort, 45 "gtk": GtkPort, 46 "mac": MacPort, 47 "qt": QtPort, 48 } 49 49 # FIXME: We should default to WinPort on Windows. 50 return MacPort50 return ports.get(port_name, MacPort) 51 51 52 52 @classmethod … … 79 79 def flag(cls): 80 80 return "--port=mac" 81 82 83 class GtkPort(WebKitPort): 84 @classmethod 85 def name(cls): 86 return "Gtk" 87 88 @classmethod 89 def flag(cls): 90 return "--port=gtk" 91 92 @classmethod 93 def build_webkit_command(cls): 94 command = WebKitPort.build_webkit_command() 95 command.append("--gtk") 96 return command 97 98 @classmethod 99 def run_webkit_tests_command(cls): 100 command = WebKitPort.run_webkit_tests_command() 101 command.append("--gtk") 102 return command 81 103 82 104 -
trunk/WebKitTools/Scripts/modules/webkitport_unittest.py
r51730 r52240 30 30 import unittest 31 31 32 from modules.webkitport import WebKitPort, MacPort, QtPort, ChromiumPort32 from modules.webkitport import WebKitPort, MacPort, GtkPort, QtPort, ChromiumPort 33 33 34 34 class WebKitPortTest(unittest.TestCase): … … 38 38 self.assertEquals(MacPort.run_webkit_tests_command(), [WebKitPort.script_path("run-webkit-tests")]) 39 39 self.assertEquals(MacPort.build_webkit_command(), [WebKitPort.script_path("build-webkit")]) 40 41 def test_gtk_port(self): 42 self.assertEquals(GtkPort.name(), "Gtk") 43 self.assertEquals(GtkPort.flag(), "--port=gtk") 44 self.assertEquals(GtkPort.run_webkit_tests_command(), [WebKitPort.script_path("run-webkit-tests"), "--gtk"]) 45 self.assertEquals(GtkPort.build_webkit_command(), [WebKitPort.script_path("build-webkit"), "--gtk"]) 40 46 41 47 def test_qt_port(self):
Note: See TracChangeset
for help on using the changeset viewer.