Changeset 52241 in webkit

Timestamp:

Dec 16, 2009 11:52:52 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2009-12-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make UpdateStep quiet
​https://bugs.webkit.org/show_bug.cgi?id=32599

• Scripts/modules/buildsteps.py:
• Scripts/modules/buildsteps_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/buildsteps.py (modified) (1 diff)
• Scripts/modules/buildsteps_unittest.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-16  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] Make UpdateStep quiet
+        https://bugs.webkit.org/show_bug.cgi?id=32599
+
+        * Scripts/modules/buildsteps.py:
+        * Scripts/modules/buildsteps_unittest.py:
+
 2009-12-16  Evan Martin  <evan@chromium.org>
 

trunk/WebKitTools/Scripts/modules/buildsteps.py

@@ -162 +162 @@
             return
         log("Updating working directory")
-        self._tool.executive.run_and_throw_if_fail(self.port().update_webkit_command())
+        self._tool.executive.run_and_throw_if_fail(self.port().update_webkit_command(), quiet=True)
 
 

trunk/WebKitTools/Scripts/modules/buildsteps_unittest.py

@@ -29 +29 @@
 import unittest
 
-from modules.buildsteps import UpdateChangelogsWithReviewerStep
+from modules.buildsteps import UpdateChangelogsWithReviewerStep, UpdateStep
 from modules.mock_bugzillatool import MockBugzillaTool
 from modules.outputcapture import OutputCapture
+from modules.mock import Mock
+
 
 class UpdateChangelogsWithReviewerStepTest(unittest.TestCase):
@@ -39 +41 @@
         expected_stderr = "0 reviewed patches on bug 1, cannot infer reviewer.\n"
         capture.assert_outputs(self, step._guess_reviewer_from_bug, [1], expected_stderr=expected_stderr)
+
+
+class StepsTest(unittest.TestCase):
+    def _run_step(self, step, options, state=None):
+        if not state:
+            state = {}
+        step(MockBugzillaTool(), options).run(state)
+
+    def test_update_step(self):
+        options = Mock()
+        options.update = True
+        self._run_step(UpdateStep, options)