Changeset 52279 in webkit


Ignore:
Timestamp:
Dec 17, 2009 12:53:12 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-17 Pavel Feldman <​pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: Incorrect Doctype.

REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
​https://bugs.webkit.org/show_bug.cgi?id=32671

  • inspector/elements-panel-structure-expected.txt:
  • inspector/elements-panel-structure.html:

2009-12-17 Pavel Feldman <​pfeldman@dhcp-172-28-174-220.spb.corp.google.com>

Reviewed by Timothy Hatcher.

Web Inspector: Incorrect Doctype.

REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
​https://bugs.webkit.org/show_bug.cgi?id=32671

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r52273 r52279  
     12009-12-17  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Incorrect Doctype.
     6
     7        REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
     8        https://bugs.webkit.org/show_bug.cgi?id=32671
     9
     10        * inspector/elements-panel-structure-expected.txt:
     11        * inspector/elements-panel-structure.html:
     12
    1132009-12-17  Chris Fleizach  <cfleizach@apple.com>
    214

  • trunk/LayoutTests/inspector/elements-panel-structure-expected.txt

    r50582 r52279  
    22
    33
     4<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
    45<html>
    56<head>

  • trunk/LayoutTests/inspector/elements-panel-structure.html

    r50582 r52279  
     1<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
    12<html>
    23<head>

  • trunk/WebCore/ChangeLog

    r52278 r52279  
     12009-12-17  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Incorrect Doctype.
     6
     7        REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
     8        https://bugs.webkit.org/show_bug.cgi?id=32671
     9
     10        * inspector/InspectorDOMAgent.cpp:
     11        (WebCore::InspectorDOMAgent::buildObjectForNode):
     12        * inspector/front-end/DOMAgent.js:
     13        (WebInspector.DOMNode):
     14
    1152009-12-17  Benjamin Otte  <otte@gnome.org>
    216

  • trunk/WebCore/inspector/InspectorDOMAgent.cpp

    r51601 r52279  
    4040#include "DOMWindow.h"
    4141#include "Document.h"
     42#include "DocumentType.h"
    4243#include "Event.h"
    4344#include "EventListener.h"
    … …  
    523524            value.set("children", children);
    524525    }
     526    if (node->nodeType() == Node::DOCUMENT_TYPE_NODE) {
     527        DocumentType* docType = static_cast<DocumentType*>(node);
     528        value.set("publicId", docType->publicId());
     529        value.set("systemId", docType->systemId());
     530        value.set("internalSubset", docType->internalSubset());
     531    }
    525532    return value;
    526533}

  • trunk/WebCore/inspector/front-end/DOMAgent.js

    r51846 r52279  
    6161    this._matchedCSSRules = [];
    6262
    63     if (this.nodeType == Node.ELEMENT_NODE) {
     63    if (this.nodeType === Node.ELEMENT_NODE) {
    6464        // HTML and BODY from internal iframes should not overwrite top-level ones.
    6565        if (!this.ownerDocument.documentElement && this.nodeName === "HTML")
    … …  
    6767        if (!this.ownerDocument.body && this.nodeName === "BODY")
    6868            this.ownerDocument.body = this;
     69    } else if (this.nodeType === Node.DOCUMENT_TYPE_NODE) {
     70        this.publicId = payload.publicId;
     71        this.systemId = payload.systemId;
     72        this.internalSubset = payload.internalSubset;
    6973    }
    7074}
Note: See TracChangeset for help on using the changeset viewer.