Changeset 52295 in webkit


Ignore:
Timestamp:
Dec 17, 2009 5:28:27 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-17 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Command.show_in_main_help should default to False
​https://bugs.webkit.org/show_bug.cgi?id=32686

  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/queries.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/multicommandtool.py:
Location:
trunk/WebKitTools
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r52284 r52295  
     12009-12-17  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Command.show_in_main_help should default to False
     6        https://bugs.webkit.org/show_bug.cgi?id=32686
     7
     8        * Scripts/modules/commands/download.py:
     9        * Scripts/modules/commands/queries.py:
     10        * Scripts/modules/commands/queues.py:
     11        * Scripts/modules/commands/upload.py:
     12        * Scripts/modules/multicommandtool.py:
     13
    1142009-12-17  Alejandro G. Castro  <alex@igalia.com>
    215

  • trunk/WebKitTools/Scripts/modules/commands/download.py

    r52136 r52295  
    6969    name = "build"
    7070    help_text = "Update working copy and build"
    71     argument_names = ""
    72     show_in_main_help = False
    7371    steps = [
    7472        CleanWorkingDirectoryStep,
    … …  
    167165    help_text = "Run check-webkit-style on the specified attachments"
    168166    argument_names = "ATTACHMENT_ID [ATTACHMENT_IDS]"
    169     show_in_main_help = False
    170167    main_steps = [
    171168        CleanWorkingDirectoryStep,
    … …  
    180177    help_text = "Apply and build patches from bugzilla"
    181178    argument_names = "ATTACHMENT_ID [ATTACHMENT_IDS]"
    182     show_in_main_help = False
    183179    main_steps = [
    184180        CleanWorkingDirectoryStep,

  • trunk/WebKitTools/Scripts/modules/commands/queries.py

    r51959 r52295  
    4040class BugsToCommit(Command):
    4141    name = "bugs-to-commit"
    42     show_in_main_help = False
    4342    def __init__(self):
    4443        Command.__init__(self, "List bugs in the commit-queue")
    … …  
    5251class PatchesToCommit(Command):
    5352    name = "patches-to-commit"
    54     show_in_main_help = False
    5553    def __init__(self):
    5654        Command.__init__(self, "List patches in the commit-queue")
    … …  
    6563class PatchesToCommitQueue(Command):
    6664    name = "patches-to-commit-queue"
    67     show_in_main_help = False
    6865    def __init__(self):
    6966        options = [
    … …  
    10097class PatchesToReview(Command):
    10198    name = "patches-to-review"
    102     show_in_main_help = False
    10399    def __init__(self):
    104100        Command.__init__(self, "List patches that are pending review")
    … …  
    113109class ReviewedPatches(Command):
    114110    name = "reviewed-patches"
    115     show_in_main_help = False
    116111    def __init__(self):
    117112        Command.__init__(self, "List r+'d patches on a bug", "BUGID")

  • trunk/WebKitTools/Scripts/modules/commands/queues.py

    r52242 r52295  
    4545
    4646class AbstractQueue(Command, WorkQueueDelegate):
    47     show_in_main_help = False
    4847    watchers = "webkit-bot-watchers@googlegroups.com"
    4948    def __init__(self, options=None): # Default values should never be collections (like []) as default values are shared between invocations

  • trunk/WebKitTools/Scripts/modules/commands/upload.py

    r52148 r52295  
    4545class CommitMessageForCurrentDiff(Command):
    4646    name = "commit-message"
    47     show_in_main_help = False
    4847    def __init__(self):
    4948        Command.__init__(self, "Print a commit message suitable for the uncommitted changes")
    … …  
    5655class ObsoleteAttachments(Command):
    5756    name = "obsolete-attachments"
    58     show_in_main_help = False
    5957    def __init__(self):
    6058        Command.__init__(self, "Mark all attachments on a bug as obsolete", "BUGID")

  • trunk/WebKitTools/Scripts/modules/multicommandtool.py

    r51403 r52295  
    4141class Command(object):
    4242    name = None
    43     # show_in_main_help = False # Subclasses must define show_in_main_help, we leave it out here to enforce that.
     43    show_in_main_help = False
    4444    def __init__(self, help_text, argument_names=None, options=None, requires_local_commits=False):
    4545        self.help_text = help_text
    … …  
    129129class HelpCommand(Command):
    130130    name = "help"
    131     show_in_main_help = False
    132131
    133132    def __init__(self):
Note: See TracChangeset for help on using the changeset viewer.