Changeset 52339 in webkit

Timestamp:

Dec 18, 2009 1:45:53 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-18 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

move bugzilla.py off of urllib2
​https://bugs.webkit.org/show_bug.cgi?id=32729

• Scripts/modules/bugzilla.py: use mechanize for all url fetching.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/modules/bugzilla.py (modified) (6 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-18  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by David Levin.
+
+        move bugzilla.py off of urllib2
+        https://bugs.webkit.org/show_bug.cgi?id=32729
+
+        * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
+
 2009-12-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/WebKitTools/Scripts/modules/bugzilla.py

@@ -32 +32 @@
 import re
 import subprocess
-import urllib2
 
 from datetime import datetime # used in timestamp()
@@ -118 +117 @@
         log("Fetching: %s" % bug_url)
 
-        page = urllib2.urlopen(bug_url)
+        page = self.browser.open(bug_url)
         soup = BeautifulSoup(page)
 
@@ -137 +136 @@
         attachment_url = self.attachment_url_for_id(attachment_id, 'edit')
         log("Fetching: %s" % attachment_url)
-        page = urllib2.urlopen(attachment_url)
+        page = self.browser.open(attachment_url)
         return self._parse_bug_id_from_attachment_page(page)
 
@@ -159 +158 @@
     def fetch_title_from_bug(self, bug_id):
         bug_url = self.bug_url_for_bug_id(bug_id, xml=True)
-        page = urllib2.urlopen(bug_url)
+        page = self.browser.open(bug_url)
         soup = BeautifulSoup(page)
         return soup.find('short_desc').string
@@ -233 +232 @@
 
     def _fetch_bug_ids_advanced_query(self, query):
-        page = urllib2.urlopen(query)
+        page = self.browser.open(query)
         soup = BeautifulSoup(page)
 
@@ -251 +250 @@
 
     def _fetch_attachment_ids_request_query(self, query):
-        return self._parse_attachment_ids_request_query(urllib2.urlopen(query))
+        return self._parse_attachment_ids_request_query(self.browser.open(query))
 
     def fetch_bug_ids_from_commit_queue(self):