Changeset 52377 in webkit


Ignore:
Timestamp:
Dec 18, 2009 10:05:14 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2009-12-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add watches for EWS
https://bugs.webkit.org/show_bug.cgi?id=32767

dglazkov wanted to be added.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/queues.py:
Location:
trunk/WebKitTools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r52339 r52377  
     12009-12-18  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Add watches for EWS
     6        https://bugs.webkit.org/show_bug.cgi?id=32767
     7
     8        dglazkov wanted to be added.
     9
     10        * Scripts/modules/bugzilla.py:
     11        * Scripts/modules/commands/early_warning_system.py:
     12        * Scripts/modules/commands/queues.py:
     13
    1142009-12-18  Eric Seidel  <eric@webkit.org>
    215
  • trunk/WebKitTools/Scripts/modules/bugzilla.py

    r52339 r52377  
    467467        self.browser.submit()
    468468
    469     def add_cc_to_bug(self, bug_id, email_address):
     469    def add_cc_to_bug(self, bug_id, email_address_list):
    470470        self.authenticate()
    471471
     
    476476        self.browser.open(self.bug_url_for_bug_id(bug_id))
    477477        self.browser.select_form(name="changeform")
    478         self.browser["newcc"] = email_address
     478        self.browser["newcc"] = email_address_list.join(", ")
    479479        self.browser.submit()
    480480
     
    491491        self.browser["comment"] = comment_text
    492492        if cc:
    493             self.browser["newcc"] = cc
     493            self.browser["newcc"] = cc.join(", ")
    494494        self.browser.submit()
    495495
  • trunk/WebKitTools/Scripts/modules/commands/early_warning_system.py

    r52242 r52377  
    8989    name = "chromium-ews"
    9090    port_name = "chromium"
     91    watchers = AbstractEarlyWarningSystem.watchers + [
     92        "dglazkov@chromium.org",
     93    ]
  • trunk/WebKitTools/Scripts/modules/commands/queues.py

    r52295 r52377  
    4545
    4646class AbstractQueue(Command, WorkQueueDelegate):
    47     watchers = "webkit-bot-watchers@googlegroups.com"
     47    watchers = [
     48        "webkit-bot-watchers@googlegroups.com",
     49    ]
    4850    def __init__(self, options=None): # Default values should never be collections (like []) as default values are shared between invocations
    4951        options_list = (options or []) + [
Note: See TracChangeset for help on using the changeset viewer.