Changeset 52448 in webkit


Ignore:
Timestamp:
Dec 21, 2009 10:58:24 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-21 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Test that dragging an SVG as <img> doesn't crash the browser.
Note that this only works in debug mode as it's a failing assert.

​https://bugs.webkit.org/show_bug.cgi?id=32511

  • fast/images/drag-svg-as-image.html: Added.
  • platform/qt/Skipped: fast/images/drag-svg-as-image.html added.

2009-12-21 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fix assertion failure when dragging an SVG image.
​https://bugs.webkit.org/show_bug.cgi?id=32511

Test: fast/images/drag-svg-as-image.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::filenameExtension): Return "svg"
  • svg/graphics/SVGImage.h:
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r52446 r52448  
     12009-12-21  Andreas Kling  <andreas.kling@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Test that dragging an SVG as <img> doesn't crash the browser.
     6        Note that this only works in debug mode as it's a failing assert.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=32511
     9
     10        * fast/images/drag-svg-as-image.html: Added.
     11        * platform/qt/Skipped: fast/images/drag-svg-as-image.html added.
     12
    1132009-12-21  Nate Chapin  <japhet@chromium.org>
    214

  • trunk/LayoutTests/platform/qt/Skipped

    r52236 r52448  
    249249fast/events/drag-file-crash.html
    250250http/tests/security/clipboard/clipboard-file-access.html
     251
     252# Missing drag & drop functionality in DRT
     253fast/images/drag-svg-as-image.html
    251254
    252255# ------- missing eventSender.zoomPageIn

  • trunk/WebCore/ChangeLog

    r52447 r52448  
     12009-12-21  Andreas Kling  <andreas.kling@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Fix assertion failure when dragging an SVG image.
     6        https://bugs.webkit.org/show_bug.cgi?id=32511
     7
     8        Test: fast/images/drag-svg-as-image.html
     9
     10        * svg/graphics/SVGImage.cpp:
     11        (WebCore::SVGImage::filenameExtension): Return "svg"
     12        * svg/graphics/SVGImage.h:
     13
    1142009-12-17  Philippe Normand  <pnormand@igalia.com>
    215

  • trunk/WebCore/svg/graphics/SVGImage.cpp

    r52314 r52448  
    269269}
    270270
     271String SVGImage::filenameExtension() const
     272{
     273    return "svg";
     274}
     275
    271276}
    272277

  • trunk/WebCore/svg/graphics/SVGImage.h

    r51212 r52448  
    4848        virtual ~SVGImage();
    4949
     50        virtual String filenameExtension() const;
     51
    5052        virtual void setContainerSize(const IntSize&);
    5153        virtual bool usesContainerSize() const;
Note: See TracChangeset for help on using the changeset viewer.