Changeset 52454 in webkit

Timestamp:

Dec 21, 2009 1:26:43 PM (14 years ago)

Author:

pkasting@chromium.org

Message:

Add support for V8 Date binding.
​https://bugs.webkit.org/show_bug.cgi?id=32699

Patch by Kent Tamura <​tkent@chromium.org> on 2009-12-19
Reviewed by Adam Barth.

This implements the same behavior as the recent change of
CodeGeneratorJS.pm and JSDOMBinding.cpp.

• bindings/scripts/CodeGeneratorV8.pm: Produce toWebCoreDate() or v8DateOrNull() for Date type.
• bindings/v8/V8Binding.cpp:

(WebCore::toWebCoreDate):

Converts a JavaScript object to a double representing Date.

(WebCore::v8DateOrNull):

Converts a double representing Date to a JavaScript Date object or null.

• bindings/v8/V8Binding.h: Declare toWebCoreDate() and v8DateOrNull().
• html/HTMLInputElement.idl: Delete V8_BINGIN exclusion for valueAsDate.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (4 diffs)
• bindings/v8/V8Binding.cpp (modified) (1 diff)
• bindings/v8/V8Binding.h (modified) (1 diff)
• html/HTMLInputElement.idl (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-19  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Add support for V8 Date binding.
+        https://bugs.webkit.org/show_bug.cgi?id=32699
+
+        This implements the same behavior as the recent change of
+        CodeGeneratorJS.pm and JSDOMBinding.cpp.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+          Produce toWebCoreDate() or v8DateOrNull() for Date type.
+        * bindings/v8/V8Binding.cpp:
+        (WebCore::toWebCoreDate):
+          Converts a JavaScript object to a double representing Date.
+        (WebCore::v8DateOrNull):
+          Converts a double representing Date to a JavaScript Date object or null.
+        * bindings/v8/V8Binding.h: Declare toWebCoreDate() and v8DateOrNull().
+        * html/HTMLInputElement.idl: Delete V8_BINGIN exclusion for valueAsDate.
+
 2009-12-21  Darin Adler  <darin@apple.com>
 

trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -157 +157 @@
     # When we're finished with the one-file-per-class
     # reorganization, we won't need these special cases.
-    if ($codeGenerator->IsPrimitiveType($type) or AvoidInclusionOfType($type)) {
+    if ($codeGenerator->IsPrimitiveType($type) or AvoidInclusionOfType($type) or $type eq "Date") {
     } elsif ($type =~ /SVGPathSeg/) {
         $joinedName = $type;
@@ -1973 +1973 @@
     return "unsigned" if $type eq "unsigned int";
     return "Node*" if $type eq "EventTarget" and $isParameter;
+    return "double" if $type eq "Date";
 
     return "String" if $type eq "DOMUserData";  # FIXME: Temporary hack?
@@ -2107 +2108 @@
     return "static_cast<Range::CompareHow>($value->Int32Value())" if $type eq "CompareHow";
     return "static_cast<SVGPaint::SVGPaintType>($value->ToInt32()->Int32Value())" if $type eq "SVGPaintType";
+    return "toWebCoreDate($value)" if $type eq "Date";
 
     if ($type eq "DOMString" or $type eq "DOMUserData") {
@@ -2369 +2371 @@
     }
 
+    if ($type eq "Date") {
+        return "return v8DateOrNull($value);";
+    }
+
     else {
         $implIncludes{"wtf/RefCounted.h"} = 1;

trunk/WebCore/bindings/v8/V8Binding.cpp

@@ -240 +240 @@
 }
 
+double toWebCoreDate(v8::Handle<v8::Value> object)
+{
+    return (object->IsDate() || object->IsNumber()) ? object->NumberValue() : std::numeric_limits<double>::quiet_NaN();
+}
+
+v8::Handle<v8::Value> v8DateOrNull(double value)
+{
+    if (isfinite(value))
+        return v8::Date::New(value);
+    return v8::Null();
+}
 
 template <class S> struct StringTraits

trunk/WebCore/bindings/v8/V8Binding.h

@@ -206 +206 @@
 
     v8::Handle<v8::Value> v8StringOrFalse(const String& str);
+
+    double toWebCoreDate(v8::Handle<v8::Value> object);
+
+    v8::Handle<v8::Value> v8DateOrNull(double value);
     
     v8::Persistent<v8::FunctionTemplate> createRawTemplate();

trunk/WebCore/html/HTMLInputElement.idl

@@ -68 +68 @@
                  attribute [ConvertNullToNullString] DOMString useMap;
                  attribute [ConvertNullToNullString] DOMString value;
-#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT && !(defined(V8_BINDING) && V8_BINDING)
-                 // FIXME: Add Date support for V8, Objective-C, and COM.
+#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
+                 // FIXME: Add Date support for Objective-C and COM.
                  attribute Date            valueAsDate setter raises(DOMException);
 #endif