Changeset 52501 in webkit

Timestamp:

Dec 22, 2009 2:18:43 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-22 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

validate-committer-lists fails when run from an SVN checkout
​https://bugs.webkit.org/show_bug.cgi?id=31974

• Scripts/validate-committer-lists:
  • Make it print a warning message instead of throwing an exception when running from an SVN checkout.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/validate-committer-lists (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2009-12-22  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        validate-committer-lists fails when run from an SVN checkout
+        https://bugs.webkit.org/show_bug.cgi?id=31974
+
+        * Scripts/validate-committer-lists:
+         - Make it print a warning message instead of throwing
+           an exception when running from an SVN checkout.
+
 2009-12-22  Philippe Normand  <pnormand@igalia.com>
 

trunk/WebKitTools/Scripts/validate-committer-lists

@@ -39 +39 @@
 from modules.committers import CommitterList
 from modules.logging import log, error
+from modules.scm import Git
 
 # WebKit includes a built copy of BeautifulSoup in Scripts/modules
@@ -244 +245 @@
     committer_list = CommitterList()
     CommitterListFromMailingList().check_for_emails_missing_from_list(committer_list)
-
+ 
+    if not Git.in_working_directory("."):
+        print """\n\nWARNING: validate-committer-lists requires a git checkout.
+The following checks are disabled:
+ - List of committers ordered by last commit
+ - List of historical committers missing from committers.py
+"""
+        return 1
     svn_committer_list = CommitterListFromGit()
     svn_committer_list.print_possibly_expired_committers(committer_list)