Changeset 52539 in webkit

Timestamp:

Dec 23, 2009 6:23:38 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-23 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Eric Seidel.

PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.

This method should limit the current painting window to the bounds of the given
image, but it did not. Due to this bug, unnecessary contents were rendered in
some (limited) situations.

[Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
​https://bugs.webkit.org/show_bug.cgi?id=32817

No new tests, because this is a fix of an existing test which is currently failing in
Chromium.

• platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginLayerClippedToImage): Add clipRect() call.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/skia/PlatformContextSkia.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-23  Yuta Kitamura  <yutak@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.
+        
+        This method should limit the current painting window to the bounds of the given
+        image, but it did not. Due to this bug, unnecessary contents were rendered in
+        some (limited) situations.
+
+        [Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
+        https://bugs.webkit.org/show_bug.cgi?id=32817
+        
+        No new tests, because this is a fix of an existing test which is currently failing in
+        Chromium.
+
+        * platform/graphics/skia/PlatformContextSkia.cpp:
+        (PlatformContextSkia::beginLayerClippedToImage): Add clipRect() call.
+
 2009-12-23  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/WebCore/platform/graphics/skia/PlatformContextSkia.cpp

@@ -235 +235 @@
     SkRect bounds = { SkFloatToScalar(rect.x()), SkFloatToScalar(rect.y()),
                       SkFloatToScalar(rect.right()), SkFloatToScalar(rect.bottom()) };
-                      
+
+    canvas()->clipRect(bounds);
     canvas()->saveLayerAlpha(&bounds, 255,
                              static_cast<SkCanvas::SaveFlags>(SkCanvas::kHasAlphaLayer_SaveFlag | SkCanvas::kFullColorLayer_SaveFlag));