Changeset 52608 in webkit


Ignore:
Timestamp:
Dec 28, 2009 10:33:19 PM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Fixed isKeypadEvent behavior for chromium/Mac to correctly report
keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
​https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • src/mac/WebInputEventFactory.mm: (WebKit::isKeypadEvent):

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Fixed isKeypadEvent behavior for Mac to correctly report keyLocation
as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
​https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • platform/mac/KeyEventMac.mm: (WebCore::isKeypadEvent):

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Added a layout-test that tests if numeric pad arrow key
events are correctly reported with keyLocation as
DOM_KEY_LOCATION_NUMPAD. Currently this test only passes on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=28247

  • fast/events/keydown-numpad-keys-expected.txt: Added.
  • fast/events/keydown-numpad-keys.html: Added.
  • fast/events/script-tests/keydown-numpad-keys.js: Added. (recordKeyEvent): (testKeyEventWithLocation):
  • platform/gtk/Skipped: fast/events/keydown-numpad-keys.html added.
  • platform/qt/Skipped: fast/events/keydown-numpad-keys.html added.
  • platform/win/Skipped: fast/events/keydown-numpad-keys.html added.

2009-12-28 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Extended EventSender.keyDown method to take another (3rd) argument
for indicating the keyLocation to make numeric pad key events testable.
Expected values for the argument is one of the KeyLocationCode
specified in DOM Level 3
(​http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
​https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController keyDown:withModifiers:withLocation:]):
Location:
trunk
Files:
3 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r52607 r52608  
     12009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Added a layout-test that tests if numeric pad arrow key
     6        events are correctly reported with keyLocation as
     7        DOM_KEY_LOCATION_NUMPAD.  Currently this test only passes on Mac.
     8        https://bugs.webkit.org/show_bug.cgi?id=28247
     9
     10        * fast/events/keydown-numpad-keys-expected.txt: Added.
     11        * fast/events/keydown-numpad-keys.html: Added.
     12        * fast/events/script-tests/keydown-numpad-keys.js: Added.
     13        (recordKeyEvent):
     14        (testKeyEventWithLocation):
     15
     16        * platform/gtk/Skipped: fast/events/keydown-numpad-keys.html added.
     17        * platform/qt/Skipped: fast/events/keydown-numpad-keys.html added.
     18        * platform/win/Skipped: fast/events/keydown-numpad-keys.html added.
     19
    1202009-12-28  Mike Moretti  <webkit9@mordent.com>
    221

  • trunk/LayoutTests/platform/gtk/Skipped

    r52606 r52608  
    22602260fast/events/focusingUnloadedFrame.html
    22612261fast/events/keydown-1.html
     2262fast/events/keydown-numpad-keys.html
    22622263fast/events/label-focus.html
    22632264fast/events/mouseout-dead-node.html

  • trunk/LayoutTests/platform/qt/Skipped

    r52590 r52608  
    459459fast/events/js-keyboard-event-creation.html
    460460fast/events/keydown-1.html
     461fast/events/keydown-numpad-keys.html
    461462fast/events/keypress-insert-tab.html
    462463fast/events/mouseout-dead-node.html

  • trunk/LayoutTests/platform/win/Skipped

    r52297 r52608  
    118118# Emacs bindings are used in LayoutTests which fail on boomer. <rdar://problem/5137352>
    119119fast/events/keydown-1.html
     120
     121# No support for key event location in EventSender.
     122fast/events/keydown-numpad-keys.html
    120123
    121124# The eqqivalent of option-tab doesn not exist in Boomer <rdar://problem/5137230>

  • trunk/WebCore/ChangeLog

    r52607 r52608  
     12009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Fixed isKeypadEvent behavior for Mac to correctly report keyLocation
     6        as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
     7        https://bugs.webkit.org/show_bug.cgi?id=28247
     8
     9        Test: fast/events/keydown-numpad-keys.html
     10
     11        * platform/mac/KeyEventMac.mm:
     12        (WebCore::isKeypadEvent):
     13
    1142009-12-28  Mike Moretti  <webkit9@mordent.com>
    215

  • trunk/WebCore/platform/mac/KeyEventMac.mm

    r52063 r52608  
    369369    }
    370370
     371    if ([event modifierFlags] & NSNumericPadKeyMask)
     372        return true;
     373
    371374    switch ([event keyCode]) {
    372375        case 71: // Clear

  • trunk/WebKit/chromium/ChangeLog

    r52517 r52608  
     12009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Fixed isKeypadEvent behavior for chromium/Mac to correctly report
     6        keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
     7        https://bugs.webkit.org/show_bug.cgi?id=28247
     8
     9        Test: fast/events/keydown-numpad-keys.html
     10
     11        * src/mac/WebInputEventFactory.mm:
     12        (WebKit::isKeypadEvent):
     13
    1142009-12-22  Kenneth Russell  <kbr@google.com>
    215

  • trunk/WebKit/chromium/src/mac/WebInputEventFactory.mm

    r51095 r52608  
    9292        return false;
    9393    }
     94
     95    if ([event modifierFlags] & NSNumericPadKeyMask)
     96        return true;
    9497
    9598    switch ([event keyCode]) {

  • trunk/WebKitTools/ChangeLog

    r52604 r52608  
     12009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        Extended EventSender.keyDown method to take another (3rd) argument
     6        for indicating the keyLocation to make numeric pad key events testable.
     7        Expected values for the argument is one of the KeyLocationCode
     8        specified in DOM Level 3
     9        (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
     10        https://bugs.webkit.org/show_bug.cgi?id=28247
     11
     12        Test: fast/events/keydown-numpad-keys.html
     13
     14        * DumpRenderTree/mac/EventSendingController.mm:
     15        (+[EventSendingController isSelectorExcludedFromWebScript:]):
     16        (+[EventSendingController webScriptNameForSelector:]):
     17        (-[EventSendingController keyDown:withModifiers:withLocation:]):
     18
    1192009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>
    220

  • trunk/WebKitTools/DumpRenderTree/mac/EventSendingController.mm

    r47741 r52608  
    126126            || aSelector == @selector(enableDOMUIEventLogging:)
    127127            || aSelector == @selector(fireKeyboardEventsToElement:)
    128             || aSelector == @selector(keyDown:withModifiers:)
     128            || aSelector == @selector(keyDown:withModifiers:withLocation:)
    129129            || aSelector == @selector(leapForward:)
    130130            || aSelector == @selector(mouseDown:)
    … …  
    155155    if (aSelector == @selector(fireKeyboardEventsToElement:))
    156156        return @"fireKeyboardEventsToElement";
    157     if (aSelector == @selector(keyDown:withModifiers:))
     157    if (aSelector == @selector(keyDown:withModifiers:withLocation:))
    158158        return @"keyDown";
    159159    if (aSelector == @selector(leapForward:))
    … …  
    475475}
    476476
    477 - (void)keyDown:(NSString *)character withModifiers:(WebScriptObject *)modifiers
     477- (void)keyDown:(NSString *)character withModifiers:(WebScriptObject *)modifiers withLocation:(unsigned long)keyLocation
    478478{
    479479    NSString *eventCharacter = character;
    … …  
    538538        }
    539539    }
     540
     541    if (keyLocation == DOM_KEY_LOCATION_NUMPAD)
     542        modifierFlags |= NSNumericPadKeyMask;
    540543
    541544    [[[mainFrame frameView] documentView] layout];
Note: See TracChangeset for help on using the changeset viewer.