Changeset 52609 in webkit

Timestamp:

Dec 28, 2009 10:41:26 PM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-28 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Remove the macro ENABLE(XHTMLMP) for noscriptAreateErrorCheck in HTMLParser,
since with XHTMLMP enabled, it's not checking create Errors, and then contents inside
<noscript> are always parsed and rendered.
​https://bugs.webkit.org/show_bug.cgi?id=32706

Tests: fast/parser/noscript-with-javascript-disabled.html

fast/parser/noscript-with-javascript-enabled.html

• html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):

2009-12-28 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Add test cases for <noscript> with both Javascript enabled and disabled
​https://bugs.webkit.org/show_bug.cgi?id=32706

• fast/parser/noscript-with-javascript-disabled-expected.txt: Added.
• fast/parser/noscript-with-javascript-disabled.html: Added.
• fast/parser/noscript-with-javascript-enabled-expected.txt: Added.
• fast/parser/noscript-with-javascript-enabled.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/noscript-with-javascript-disabled-expected.txt (added)
• LayoutTests/fast/parser/noscript-with-javascript-disabled.html (added)
• LayoutTests/fast/parser/noscript-with-javascript-enabled-expected.txt (added)
• LayoutTests/fast/parser/noscript-with-javascript-enabled.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLParser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-12-28  Charles Wei  <charles.wei@torchmobile.com.cn>
+
+        Reviewed by Maciej Stachowiak.
+
+        Add test cases for <noscript> with both Javascript enabled and disabled
+        https://bugs.webkit.org/show_bug.cgi?id=32706
+
+
+        * fast/parser/noscript-with-javascript-disabled-expected.txt: Added.
+        * fast/parser/noscript-with-javascript-disabled.html: Added.
+        * fast/parser/noscript-with-javascript-enabled-expected.txt: Added.
+        * fast/parser/noscript-with-javascript-enabled.html: Added.
+
 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-28  Charles Wei  <charles.wei@torchmobile.com.cn>
+
+        Reviewed by Maciej Stachowiak.
+
+        Remove the macro ENABLE(XHTMLMP) for noscriptAreateErrorCheck in HTMLParser,
+        since with XHTMLMP enabled, it's not checking create Errors,  and then contents inside 
+        <noscript> are always parsed and rendered.
+        https://bugs.webkit.org/show_bug.cgi?id=32706
+
+        Tests: fast/parser/noscript-with-javascript-disabled.html
+               fast/parser/noscript-with-javascript-enabled.html
+
+        * html/HTMLParser.cpp:
+        (WebCore::HTMLParser::getNode):
+
 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
 

trunk/WebCore/html/HTMLParser.cpp

@@ -943 +943 @@
         gFunctionMap.set(noembedTag.localName().impl(), &HTMLParser::noembedCreateErrorCheck);
         gFunctionMap.set(noframesTag.localName().impl(), &HTMLParser::noframesCreateErrorCheck);
-#if !ENABLE(XHTMLMP)
         gFunctionMap.set(noscriptTag.localName().impl(), &HTMLParser::noscriptCreateErrorCheck);
-#endif
         gFunctionMap.set(olTag.localName().impl(), &HTMLParser::pCloserCreateErrorCheck);
         gFunctionMap.set(pTag.localName().impl(), &HTMLParser::pCloserCreateErrorCheck);