Changeset 52612 in webkit


Ignore:
Timestamp:
Dec 29, 2009 12:26:32 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989

Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.

Unskip some http/loading tests which succeed now.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):

2009-12-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989

Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.

Unskip some http/loading tests which succeed now.

  • platform/qt/Skipped:

2009-12-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989

Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.

Unskip some http/loading tests which succeed now.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r52611 r52612  
     12009-12-29  Jakub Wieczorek  <faw217@gmail.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Qt] DRT: Frame loader callbacks differ from the Mac port
     6        https://bugs.webkit.org/show_bug.cgi?id=32989
     7
     8        Remove messages from the callbacks that should not dump them to match
     9        the expected results for the http/loading tests.
     10
     11        Unskip some http/loading tests which succeed now.
     12
     13        * platform/qt/Skipped:
     14
    1152009-12-29  Robert Hogan  <robert@roberthogan.net>
    216
  • trunk/LayoutTests/platform/qt/Skipped

    r52611 r52612  
    3030
    3131# Failing HTTP Loading tests
    32 http/tests/loading/bad-server-subframe.html
    3332http/tests/loading/bad-scheme-subframe.html
    34 http/tests/loading/basic-auth-resend-wrong-credentials.html
    35 http/tests/loading/basic.html
    36 http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
    37 http/tests/loading/empty-subframe.html
    3833http/tests/loading/gmail-assert-on-load.html
    39 http/tests/loading/location-hash-reload-cycle.html
    40 http/tests/loading/onload-vs-immediate-refresh.pl
    41 http/tests/loading/preload-img-test.html
    4234http/tests/loading/redirect-methods.html
    43 http/tests/loading/redirect-with-no-location-crash.html
    4435http/tests/loading/simple-subframe.html
    45 http/tests/loading/slow-parsing-subframe.html
    4636http/tests/loading/text-content-type-with-binary-extension.html
    4737
     
    48354825fast/loader/policy-delegate-action-hit-test-zoomed.html
    48364826fast/loader/reload-policy-delegate.html
    4837 fast/loading/subframe-removes-itself.html
    48384827platform/qt/fast/events/event-sender-keydown-frame.html
    48394828plugins/netscape-plugin-setwindow-size-2.html
     
    48854874# No authentication challenge handling
    48864875http/tests/loading/basic-credentials-sent-automatically.html
     4876http/tests/loading/basic-auth-resend-wrong-credentials.html
    48874877
    48884878# This port doesn't support detecting slow unload handlers.
     
    50945084fast/repaint/inline-overflow.html
    50955085fast/repaint/inline-relative-positioned.html
    5096 http/tests/loading/state-object-security-exception.html
    50975086http/tests/local/file-url-sent-as-referer.html
    50985087http/tests/misc/bubble-drag-events.html
  • trunk/WebKit/qt/ChangeLog

    r52611 r52612  
     12009-12-29  Jakub Wieczorek  <faw217@gmail.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Qt] DRT: Frame loader callbacks differ from the Mac port
     6        https://bugs.webkit.org/show_bug.cgi?id=32989
     7
     8        Remove messages from the callbacks that should not dump them to match
     9        the expected results for the http/loading tests.
     10
     11        Unskip some http/loading tests which succeed now.
     12
     13        * WebCoreSupport/FrameLoaderClientQt.cpp:
     14        (WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):
     15        (WebCore::FrameLoaderClientQt::dispatchWillClose):
     16        (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
     17        (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
     18
    1192009-12-29  Robert Hogan  <robert@roberthogan.net>
    220
  • trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

    r51759 r52612  
    332332void FrameLoaderClientQt::dispatchWillClose()
    333333{
    334     if (dumpFrameLoaderCallbacks)
    335         printf("%s - willCloseFrame\n", qPrintable(drtDescriptionSuitableForTestResult(m_frame)));
    336334}
    337335
     
    600598void FrameLoaderClientQt::dispatchDidReceiveIcon()
    601599{
    602     if (dumpFrameLoaderCallbacks)
    603         printf("%s - didReceiveIconForFrame\n", qPrintable(drtDescriptionSuitableForTestResult(m_frame)));
    604 
    605600    if (m_webFrame) {
    606601        emit m_webFrame->iconChanged();
     
    626621    if (world != mainThreadNormalWorld())
    627622        return;
    628 
    629     if (dumpFrameLoaderCallbacks)
    630         printf("%s - didClearWindowObjectForFrame\n", qPrintable(drtDescriptionSuitableForTestResult(m_frame)));
    631623
    632624    if (m_webFrame)
  • trunk/WebKitTools/ChangeLog

    r52611 r52612  
     12009-12-29  Jakub Wieczorek  <faw217@gmail.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Qt] DRT: Frame loader callbacks differ from the Mac port
     6        https://bugs.webkit.org/show_bug.cgi?id=32989
     7
     8        Remove messages from the callbacks that should not dump them to match
     9        the expected results for the http/loading tests.
     10
     11        Unskip some http/loading tests which succeed now.
     12
     13        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
     14        (WebCore::DumpRenderTree::dump):
     15
    1162009-12-29  Robert Hogan  <robert@roberthogan.net>
    217
  • trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp

    r52611 r52612  
    609609void DumpRenderTree::dump()
    610610{
     611    // Prevent any further frame load callbacks from appearing after we dump the result.
     612    qt_dump_frame_loader(false);
     613
    611614    QWebFrame *mainFrame = m_page->mainFrame();
    612615
Note: See TracChangeset for help on using the changeset viewer.