Changeset 52625 in webkit


Ignore:
Timestamp:
Dec 29, 2009 9:44:32 AM (14 years ago)
Author:
eric@webkit.org
Message:

2009-12-29 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html


Related to https://bugs.webkit.org/show_bug.cgi?id=23806


If an embedded document is loaded within a page and it has an empty
URL, use a blank URL for the load request.


https://bugs.webkit.org/show_bug.cgi?id=33017

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):

2009-12-29 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html


Related to https://bugs.webkit.org/show_bug.cgi?id=23806


If an embedded document is loaded within a page and it has an empty
URL, use a blank URL for the load request.


https://bugs.webkit.org/show_bug.cgi?id=33017

  • platform/qt/Skipped:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r52620 r52625  
     12009-12-29  Robert Hogan  <robert@roberthogan.net>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html
     6       
     7        Related to https://bugs.webkit.org/show_bug.cgi?id=23806
     8       
     9        If an embedded document is loaded within a page and it has an empty
     10        URL, use a blank URL for the load request.
     11       
     12        https://bugs.webkit.org/show_bug.cgi?id=33017
     13
     14        * platform/qt/Skipped:
     15
    1162009-12-29  Kent Tamura  <tkent@chromium.org>
    217
  • trunk/LayoutTests/platform/qt/Skipped

    r52612 r52625  
    125125
    126126# ------- crashes
    127 fast/loader/empty-embed-src-attribute.html
    128127fast/text/find-hidden-text.html
    129128
  • trunk/WebKit/qt/ChangeLog

    r52622 r52625  
     12009-12-29  Robert Hogan  <robert@roberthogan.net>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html
     6       
     7        Related to https://bugs.webkit.org/show_bug.cgi?id=23806
     8       
     9        If an embedded document is loaded within a page and it has an empty
     10        URL, use a blank URL for the load request.
     11       
     12        https://bugs.webkit.org/show_bug.cgi?id=33017
     13
     14        * WebCoreSupport/FrameLoaderClientQt.cpp:
     15        (WebCore::FrameLoaderClientQt::createFrame):
     16
    1172009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
    218
  • trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

    r52612 r52625  
    10291029
    10301030    QWebFrameData frameData(m_frame->page(), m_frame, ownerElement, name);
    1031     frameData.url = url;
     1031
     1032    if (url.isEmpty())
     1033        frameData.url = blankURL();
     1034    else
     1035        frameData.url = url;
     1036
    10321037    frameData.referrer = referrer;
    10331038    frameData.allowsScrolling = allowsScrolling;
Note: See TracChangeset for help on using the changeset viewer.