Changeset 52665 in webkit

Timestamp:

Dec 30, 2009 9:50:25 AM (14 years ago)

Author:

eric@webkit.org

Message:

2009-12-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
​https://bugs.webkit.org/show_bug.cgi?id=33054

Added invalidate() to SVGResourceClipper to reset clipData
and drawing area after attribute changes.

This fixes two LayoutTests.

• svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::invalidate):
• svg/graphics/SVGResourceClipper.h:

2009-12-30 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
​https://bugs.webkit.org/show_bug.cgi?id=33054

Drawing area should change after attribute changes in clipPath or
it's childs.

• platform/mac/svg/custom/clip-path-child-changes-expected.txt:
• platform/mac/svg/custom/clip-path-units-changes-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/svg/custom/clip-path-child-changes-expected.txt (modified) (1 diff)
• LayoutTests/platform/mac/svg/custom/clip-path-units-changes-expected.txt (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/graphics/SVGResourceClipper.cpp (modified) (1 diff)
• WebCore/svg/graphics/SVGResourceClipper.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-12-30  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        SVGResourceClipper needs to invalidate content
+        https://bugs.webkit.org/show_bug.cgi?id=33054
+
+        Drawing area should change after attribute changes in clipPath or
+        it's childs.
+
+        * platform/mac/svg/custom/clip-path-child-changes-expected.txt:
+        * platform/mac/svg/custom/clip-path-units-changes-expected.txt:
+
 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
 

trunk/LayoutTests/platform/mac/svg/custom/clip-path-child-changes-expected.txt

@@ -3 +3 @@
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600
-  RenderSVGRoot {svg} at (0,0) size 200x200
+  RenderSVGRoot {svg} at (0,0) size 100x100
     RenderSVGHiddenContainer {defs} at (0,0) size 0x0
-    RenderSVGContainer {g} at (0,0) size 200x200 [clip path="myclip"]
+    RenderSVGContainer {g} at (0,0) size 100x100 [clip path="myclip"]
       RenderPath {rect} at (0,0) size 200x200 [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,0.00 L200.00,0.00 L200.00,200.00 L0.00,200.00 Z"]
       RenderPath {rect} at (0,0) size 100x100 [fill={[type=SOLID] [color=#008000]}] [data="M0.00,0.00 L100.00,0.00 L100.00,100.00 L0.00,100.00 Z"]

trunk/LayoutTests/platform/mac/svg/custom/clip-path-units-changes-expected.txt

@@ -3 +3 @@
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600
-  RenderSVGRoot {svg} at (0,0) size 200x200
+  RenderSVGRoot {svg} at (0,0) size 100x100
     RenderSVGHiddenContainer {defs} at (0,0) size 0x0
-    RenderSVGContainer {g} at (0,0) size 200x200 [clip path="myclip"]
+    RenderSVGContainer {g} at (0,0) size 100x100 [clip path="myclip"]
       RenderPath {rect} at (0,0) size 200x200 [fill={[type=SOLID] [color=#FF0000]}] [data="M0.00,0.00 L200.00,0.00 L200.00,200.00 L0.00,200.00 Z"]
       RenderPath {rect} at (0,0) size 100x100 [fill={[type=SOLID] [color=#008000]}] [data="M0.00,0.00 L100.00,0.00 L100.00,100.00 L0.00,100.00 Z"]

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-30  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        SVGResourceClipper needs to invalidate content
+        https://bugs.webkit.org/show_bug.cgi?id=33054
+
+        Added invalidate() to SVGResourceClipper to reset clipData
+        and drawing area after attribute changes.
+
+        This fixes two LayoutTests.
+
+        * svg/graphics/SVGResourceClipper.cpp:
+        (WebCore::SVGResourceClipper::resetClipData):
+        (WebCore::SVGResourceClipper::invalidate):
+        * svg/graphics/SVGResourceClipper.h:
+
 2009-12-30  Carol Szabo  <carol.szabo@nokia.com>
 

trunk/WebCore/svg/graphics/SVGResourceClipper.cpp

@@ -52 +52 @@
 {
     m_clipData.clear();
+    m_clipperBoundingBox = FloatRect();
+}
+
+void SVGResourceClipper::invalidate()
+{
+    SVGResource::invalidate();
+    resetClipData();
 }
 

trunk/WebCore/svg/graphics/SVGResourceClipper.h

@@ -67 +67 @@
         static PassRefPtr<SVGResourceClipper> create() { return adoptRef(new SVGResourceClipper); }
         virtual ~SVGResourceClipper();
-      
+
+        virtual void invalidate();
+
         void resetClipData();
         void addClipData(const Path&, WindRule, bool bboxUnits);