Changeset 52685 in webkit

Timestamp:

Dec 31, 2009 12:03:23 PM (14 years ago)

Author:

christian@webkit.org

Message:

2009-12-31 Christian Dywan <​christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] context menu overriding API is very limited
​https://bugs.webkit.org/show_bug.cgi?id=27546

Only show font menu items in rich text areas in the GTK+ port.

• platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ContextMenu.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-12-31  Christian Dywan  <christian@twotoasts.de>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] context menu overriding API is very limited
+        https://bugs.webkit.org/show_bug.cgi?id=27546
+
+        Only show font menu items in rich text areas in the GTK+ port.
+
+        * platform/ContextMenu.cpp:
+        (WebCore::ContextMenu::populate):
+
 2009-12-31  Christian Dywan  <christian@twotoasts.de>
 

trunk/WebCore/platform/ContextMenu.cpp

@@ -495 +495 @@
             appendItem(transformationsMenuItem);
 #endif
-            ContextMenuItem  FontMenuItem(SubmenuType, ContextMenuItemTagFontMenu, 
-                contextMenuItemTagFontMenu());
-            createAndAppendFontSubMenu(m_hitTestResult, FontMenuItem);
-            appendItem(FontMenuItem);
+#if PLATFORM(GTK)
+            bool shouldShowFontMenu = frame->editor()->canEditRichly();
+#else
+            bool shouldShowFontMenu = true;
+#endif
+            if (shouldShowFontMenu) {
+                ContextMenuItem FontMenuItem(SubmenuType, ContextMenuItemTagFontMenu, 
+                    contextMenuItemTagFontMenu());
+                createAndAppendFontSubMenu(m_hitTestResult, FontMenuItem);
+                appendItem(FontMenuItem);
+            }
 #if PLATFORM(MAC)
             ContextMenuItem SpeechMenuItem(SubmenuType, ContextMenuItemTagSpeechMenu, contextMenuItemTagSpeechMenu());