Changeset 52720 in webkit

Timestamp:

Jan 4, 2010 1:49:18 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-01-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add missing unit test for CommitMessageForCurrentDiff
​https://bugs.webkit.org/show_bug.cgi?id=33141

• Scripts/webkitpy/commands/upload.py:
• Scripts/webkitpy/commands/upload_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/commands/upload.py (modified) (1 diff)
• Scripts/webkitpy/commands/upload_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-04  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Add missing unit test for CommitMessageForCurrentDiff
+        https://bugs.webkit.org/show_bug.cgi?id=33141
+
+        * Scripts/webkitpy/commands/upload.py:
+        * Scripts/webkitpy/commands/upload_unittest.py:
+
 2010-01-04  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/commands/upload.py

@@ -44 +44 @@
 from webkitpy.grammar import pluralize
 from webkitpy.webkit_logging import error, log
+from webkitpy.mock import Mock
 from webkitpy.multicommandtool import AbstractDeclarativeCommmand
 
-# FIXME: Requires unit test.
 class CommitMessageForCurrentDiff(AbstractDeclarativeCommmand):
     name = "commit-message"

trunk/WebKitTools/Scripts/webkitpy/commands/upload_unittest.py

@@ -34 +34 @@
 
 class UploadCommandsTest(CommandsTest):
+    def test_commit_message_for_current_diff(self):
+        tool = MockBugzillaTool()
+        mock_commit_message_for_this_commit = Mock()
+        mock_commit_message_for_this_commit.message = lambda: "Mock message"
+        tool._scm.commit_message_for_this_commit = lambda: mock_commit_message_for_this_commit
+        expected_stdout = "Mock message\n"
+        self.assert_execute_outputs(CommitMessageForCurrentDiff(), [], expected_stdout=expected_stdout, tool=tool)
+
     def test_assign_to_committer(self):
         tool = MockBugzillaTool()