Changeset 52803 in webkit

Timestamp:

Jan 5, 2010 10:14:35 AM (14 years ago)

Author:

Adam Roben

Message:

Don't hang in WebKitAPITest if no messages have been posted

Part of <​http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

• WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
to avoid hanging if no messages have been posted.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• WebKitAPITest/tests/WebViewDestruction.cpp (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-01-05  Adam Roben  <aroben@apple.com>
+
+        Don't hang in WebKitAPITest if no messages have been posted
+
+        Part of <http://webkit.org/b/33212> Small fixes/improvements to
+        WebKitAPITest
+
+        Reviewed by Sam Weinig.
+
+        * WebKitAPITest/tests/WebViewDestruction.cpp:
+        (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
+        to avoid hanging if no messages have been posted.
+
 2010-01-05  Adam Roben  <aroben@apple.com>
 

trunk/WebKitTools/WebKitAPITest/tests/WebViewDestruction.cpp

@@ -69 +69 @@
     MSG msg;
     BOOL result;
-    while ((result = GetMessage(&msg, 0, 0, 0)) && GetTickCount() - startTickCount <= timeoutMilliseconds) {
+    while ((result = PeekMessageW(&msg, 0, 0, 0, PM_REMOVE)) && GetTickCount() - startTickCount <= timeoutMilliseconds) {
         if (result == -1)
             break;