Changeset 52943 in webkit

Timestamp:

Jan 7, 2010 12:58:14 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-01-07 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
​https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

• fast/css/css3-space-in-nth-and-lang.html: Added.
• platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.

2010-01-07 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
​https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

• css/CSSGrammar.y:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/css3-space-in-nth-and-lang.html (added)
• LayoutTests/platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSGrammar.y (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-01-07  Yuzo Fujishima  <yuzo@google.com>
+
+        Reviewed by Darin Adler.
+
+        Allow leading/trailing space for CSS nth-*() and lang().
+        https://bugs.webkit.org/show_bug.cgi?id=17248
+
+        For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
+        See the bug comments for why we don't allow space at other places.
+
+        * fast/css/css3-space-in-nth-and-lang.html: Added.
+        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
+
 2010-01-07  Chris Fleizach  <cfleizach@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-01-07  Yuzo Fujishima  <yuzo@google.com>
+
+        Reviewed by Darin Adler.
+
+        Allow leading/trailing space for CSS nth-*() and lang().
+        https://bugs.webkit.org/show_bug.cgi?id=17248
+
+        For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
+        See the bug comments for why we don't allow space at other places.
+
+        * css/CSSGrammar.y:
+
 2010-01-07  Chris Fleizach  <cfleizach@apple.com>
 

trunk/WebCore/css/CSSGrammar.y

@@ -1110 +1110 @@
     }
     // used by :nth-*(ax+b)
-    | ':' FUNCTION NTH ')' {
+    | ':' FUNCTION maybe_space NTH maybe_space ')' {
         CSSParser *p = static_cast<CSSParser*>(parser);
         $$ = p->createFloatingSelector();
         $$->m_match = CSSSelector::PseudoClass;
-        $$->setArgument($3);
+        $$->setArgument($4);
         $$->m_value = $2;
         CSSSelector::PseudoType type = $$->pseudoType();
@@ -1128 +1128 @@
     }
     // used by :nth-*
-    | ':' FUNCTION INTEGER ')' {
+    | ':' FUNCTION maybe_space INTEGER maybe_space ')' {
         CSSParser *p = static_cast<CSSParser*>(parser);
         $$ = p->createFloatingSelector();
         $$->m_match = CSSSelector::PseudoClass;
-        $$->setArgument(String::number($3));
+        $$->setArgument(String::number($4));
         $$->m_value = $2;
         CSSSelector::PseudoType type = $$->pseudoType();
@@ -1146 +1146 @@
     }
     // used by :nth-*(odd/even) and :lang
-    | ':' FUNCTION IDENT ')' {
+    | ':' FUNCTION maybe_space IDENT maybe_space ')' {
         CSSParser *p = static_cast<CSSParser*>(parser);
         $$ = p->createFloatingSelector();
         $$->m_match = CSSSelector::PseudoClass;
-        $$->setArgument($3);
+        $$->setArgument($4);
         $2.lower();
         $$->m_value = $2;