Changeset 52984 in webkit


Ignore:
Timestamp:
Jan 8, 2010 3:44:19 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52981.
​http://trac.webkit.org/changeset/52981
​https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Eric Seidel <​eric@webkit.org>

No review, rolling out r52981.
​http://trac.webkit.org/changeset/52981
​https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r52983 r52984  
     12010-01-08  Eric Seidel  <eric@webkit.org>
     2
     3        No review, rolling out r52981.
     4        http://trac.webkit.org/changeset/52981
     5        https://bugs.webkit.org/show_bug.cgi?id=33319
     6
     7        Caused two JS tests to start failing:
     8        ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js
     9
     10        * runtime/RegExpPrototype.cpp:
     11        (JSC::regExpProtoFuncToString):
     12
    1132010-01-08  Kent Hansen  <kent.hansen@nokia.com>
    214

  • trunk/JavaScriptCore/runtime/RegExpPrototype.cpp

    r52981 r52984  
    115115    if (asRegExpObject(thisValue)->get(exec, exec->propertyNames().multiline).toBoolean(exec))
    116116        postfix[index] = 'm';
    117     UString source = asRegExpObject(thisValue)->get(exec, exec->propertyNames().source).toString(exec);
    118     return jsNontrivialString(exec, makeString("/", source.size() ? source : UString("(?:)"), postfix));
     117   
     118    return jsNontrivialString(exec, makeString("/", asRegExpObject(thisValue)->get(exec, exec->propertyNames().source).toString(exec), postfix));
    119119}
    120120

  • trunk/LayoutTests/ChangeLog

    r52982 r52984  
     12010-01-08  Eric Seidel  <eric@webkit.org>
     2
     3        No review, rolling out r52981.
     4        http://trac.webkit.org/changeset/52981
     5        https://bugs.webkit.org/show_bug.cgi?id=33319
     6
     7        Caused two JS tests to start failing:
     8        ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js
     9
     10        * fast/js/kde/RegExp-expected.txt:
     11        * fast/js/kde/script-tests/RegExp.js:
     12        * fast/js/regexp-compile-expected.txt:
     13        * fast/js/script-tests/regexp-compile.js:
     14        * fast/regex/non-pattern-characters-expected.txt:
     15
    1162010-01-08  Eric Seidel  <eric@webkit.org>
    217

  • trunk/LayoutTests/fast/js/kde/RegExp-expected.txt

    r52981 r52984  
    9393FAIL Object.prototype.toString.apply(RegExp.prototype) should be [object RegExp]. Was [object RegExpPrototype].
    9494PASS typeof RegExp.prototype.toString() is 'string'
    95 PASS new RegExp().toString() is '/(?:)/'
    96 PASS (new RegExp('(?:)')).source is '(?:)'
    97 PASS /(?:)/.toString() is '/(?:)/'
    98 PASS /(?:)/.source is '(?:)'
    9995Done.
    10096PASS successfullyParsed is true

  • trunk/LayoutTests/fast/js/kde/script-tests/RegExp.js

    r52981 r52984  
    149149shouldBe("typeof RegExp.prototype.toString()", "'string'");
    150150
    151 // Empty regular expressions have string representation /(?:)/
    152 shouldBe("new RegExp().toString()", "'/(?:)/'");
    153 shouldBe("(new RegExp('(?:)')).source", "'(?:)'");
    154 shouldBe("/(?:)/.toString()", "'/(?:)/'");
    155 shouldBe("/(?:)/.source", "'(?:)'");
    156 
    157151debug("Done.");
    158152successfullyParsed = true

  • trunk/LayoutTests/fast/js/regexp-compile-expected.txt

    r52981 r52984  
    2020PASS re.toString() is '/undefined/'
    2121PASS re.toString() is '/null/'
    22 PASS re.toString() is '/(?:)/'
     22PASS re.toString() is '//'
    2323PASS re.toString() is '/z/'
    2424PASS re.lastIndex is 0

  • trunk/LayoutTests/fast/js/script-tests/regexp-compile.js

    r52981 r52984  
    3939
    4040re.compile();
    41 shouldBe("re.toString()", "'/(?:)/'");
     41shouldBe("re.toString()", "'//'"); // /(?:)/ in Firefox
    4242
    4343re.compile("z", undefined);

  • trunk/LayoutTests/fast/regex/non-pattern-characters-expected.txt

    r52981 r52984  
    157157PASS regexp.lastIndex is 2
    158158
    159 Testing regexp: /(?:)/gm
     159Testing regexp: //gm
    160160PASS regexp.test('') is true
    161161PASS regexp.lastIndex is 0
Note: See TracChangeset for help on using the changeset viewer.