Changeset 53033 in webkit


Ignore:
Timestamp:
Jan 8, 2010 6:16:17 PM (14 years ago)
Author:
ddkilzer@apple.com
Message:

<​http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button

Reviewed by Adam Barth.

This button was broken during a previous Bugzilla upgrade after
changes were made to the names of objects exposed on templates.

  • template/en/custom/attachment/reviewform.html.tmpl: Changed

attachid to attachment.id and ispatch to attachment.ispatch.
Also tweaked the format to use 4 table columns instead of 5.

Location:
trunk/BugsSite
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/BugsSite/ChangeLog

    r53020 r53033  
     12010-01-08  David Kilzer  <ddkilzer@apple.com>
     2
     3        <http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button
     4
     5        Reviewed by Adam Barth.
     6
     7        This button was broken during a previous Bugzilla upgrade after
     8        changes were made to the names of objects exposed on templates.
     9
     10        * template/en/custom/attachment/reviewform.html.tmpl: Changed
     11        attachid to attachment.id and ispatch to attachment.ispatch.
     12        Also tweaked the format to use 4 table columns instead of 5.
     13
    1142010-01-08  David Kilzer  <ddkilzer@apple.com>
    215

  • trunk/BugsSite/template/en/custom/attachment/reviewform.html.tmpl

    r53016 r53033  
    3636    {
    3737      viewing_formatted_diff = !viewing_formatted_diff;
    38       var src = "attachment.cgi?id=[% attachid %]";
     38      var src = "attachment.cgi?id=[% attachment.id %]";
    3939      var buttonText = "View Formatted Diff";
    4040      if (viewing_formatted_diff) {
    … …  
    101101</td>
    102102<td>
    103 Back to <a href="show_bug.cgi?id=[% attachment.bug_id %]" target="_top">[% terms.Bug %] #[% attachment.bug_id %]</a>
    104 </td>
    105 <td>
    106     [% IF ispatch %]
    107       <script type="text/javascript">
    108         <!--
     103    <div>Back to <a href="show_bug.cgi?id=[% attachment.bug_id %]" target="_top">[% terms.Bug %] #[% attachment.bug_id %]</a></div>
     104[% IF attachment.ispatch %]
     105    <script type="text/javascript">
     106    <!--
    109107        if (typeof document.getElementById == "function") {
    110           document.write('<button type="button" id="viewPrettyPatchButton" onclick="viewPrettyPatch();">View Plain Diff</button>');
     108          document.write('<p><button type="button" id="viewPrettyPatchButton" onclick="viewPrettyPatch();">View Plain Diff</button></p>');
    111109        }
    112         //-->
    113       </script>
    114     [% END %]
     110    //-->
     111    </script>
     112[% END %]
    115113</td>
    116114</tr>
    117115<tr>
    118 <td colspan="5">
     116<td colspan="4">
    119117Enter comments below:<br>
    120118<textarea id=comment name="comment" wrap="soft">[% quotedpatch FILTER html %]</textarea><br>
Note: See TracChangeset for help on using the changeset viewer.