Changeset 53037 in webkit


Ignore:
Timestamp:
Jan 8, 2010 11:40:02 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-01-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dmitry Titov.

bindings/v8/DOMData is missing a virtual destructor
​https://bugs.webkit.org/show_bug.cgi?id=33390

DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
but it does not have a virtual destructor. While this isn't currently causing
any leaks, since there are no instances of ChildThreadDOMData or
MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
compiler generates the following compilation error:

"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
functions and accessible non-virtual destructor"

We therefore need to add a virtual destructor to DOMData.

  • bindings/v8/DOMData.cpp: (WebCore::DOMData::~DOMData):
  • bindings/v8/DOMData.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r53036 r53037  
     12010-01-08  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Dmitry Titov.
     4
     5        bindings/v8/DOMData is missing a virtual destructor
     6        https://bugs.webkit.org/show_bug.cgi?id=33390
     7
     8        DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
     9        but it does not have a virtual destructor. While this isn't currently causing
     10        any leaks, since there are no instances of ChildThreadDOMData or
     11        MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
     12        compiler generates the following compilation error:
     13
     14        "/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
     15        functions and accessible non-virtual destructor"
     16
     17        We therefore need to add a virtual destructor to DOMData.
     18
     19        * bindings/v8/DOMData.cpp:
     20        (WebCore::DOMData::~DOMData):
     21        * bindings/v8/DOMData.h:
     22
    1232010-01-08  Daniel Bates  <dbates@webkit.org>
    224

  • trunk/WebCore/bindings/v8/DOMData.cpp

    r51915 r53037  
    4242    , m_isMainThread(WTF::isMainThread())
    4343    , m_owningThread(WTF::currentThread())
     44{
     45}
     46
     47DOMData::~DOMData()
    4448{
    4549}

  • trunk/WebCore/bindings/v8/DOMData.h

    r51998 r53037  
    4646    public:
    4747        DOMData();
     48        virtual ~DOMData();
    4849
    4950        static DOMData* getCurrent();
Note: See TracChangeset for help on using the changeset viewer.