Changeset 53053 in webkit


Ignore:
Timestamp:
Jan 10, 2010 1:30:58 PM (14 years ago)
Author:
pfeldman@chromium.org
Message:

2010-01-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspect Element selects the wrong element.
Drive-by fix that focuses dom tree upon settting focuesDOMNode.

​https://bugs.webkit.org/show_bug.cgi?id=33449

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.select):
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r53052 r53053  
     12010-01-10  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Timothy Hatcher.
     4
     5        Web Inspector: Inspect Element selects the wrong element.
     6        Drive-by fix that focuses dom tree upon settting focuesDOMNode.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=33449
     9
     10        * inspector/front-end/ElementsPanel.js:
     11        (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
     12        (WebInspector.ElementsPanel.prototype.setDocument):
     13        * inspector/front-end/treeoutline.js:
     14        (TreeElement.prototype.select):
     15
    1162010-01-10  Pavel Feldman  <pfeldman@chromium.org>
    217

  • trunk/WebCore/inspector/front-end/ElementsPanel.js

    r52556 r53053  
    228228        function selectLastSelectedNode(nodeId)
    229229        {
     230            if (this.focusedDOMNode) {
     231                // Focused node has been explicitly set while reaching out for the last selected node.
     232                return;
     233            }
    230234            var node = nodeId ? WebInspector.domAgent.nodeForId(nodeId) : 0;
    231235            selectNode.call(this, node);

  • trunk/WebCore/inspector/front-end/treeoutline.js

    r52099 r53053  
    777777
    778778    this.selected = true;
     779    this.treeOutline._childrenListNode.focus();
    779780    this.treeOutline.selectedTreeElement = this;
    780781    if (this._listItemNode)
Note: See TracChangeset for help on using the changeset viewer.